new(vx-legend): add Line, legendLabelProps, more props in renderShape #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williaster
commented
Jun 17, 2020
| @@ -122,6 +127,7 @@ export default function Legend<Datum, Output, Scale = ScaleType<Datum, Output>>( | |||
| flex={labelFlex} | |||
| margin={labelMargin} | |||
| align={labelAlign} | |||
| {...legendLabelProps} | |||
There was a problem hiding this comment.
previously this couldn't be customized at all
|
#751 should fix the CI on this |
hshoff
approved these changes
Jun 17, 2020
williaster
force-pushed
the
chris--legend-enhancements
branch
from
292854d
to
28ac8a8
Compare
33 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Enhancements
This adds some additional features + hooks to
@vx/legendwhich were needed for me to integrate theLegendcomponent in theXYChartPOC.Lineshape (now haveLine,Rect, andCircle)legendLabelPropstoLegendto support customization of label styles (and integration of theXYCharttheme)item+itemIndexinRenderShapeProvidedProps; it currently passeslabelwhich doesn't help if your logic is based off of theLegendscaledomain@hshoff @kristw