fix(vx-mock-data/cityTemperature): use better date format #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#751 should fix the CI on this |
hshoff
approved these changes
Jun 17, 2020
williaster
force-pushed
the
chris--mock-data-city-temp
branch
from
4d0421e
to
7ea2e59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💥 Breaking Changes
🚀 Enhancements
This updates the date format of the
@vx/mock-datacityTemperaturedataset fromYYYYMMDD=>YYYY-MM-DDThe old format requires parsing with something like
d3-time-format, whereas the new one can be parsed withnew Date(d). I think this is a win since it requires one few steps / dependencies for someone to use it.Testing
@hshoff @kristw