feat(grid): update scale types in vx/grid #775
Merged
+72
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristw
commented
Aug 4, 2020
| @@ -109,15 +109,15 @@ export default withTooltip<AreaProps, TooltipData>( | |||
| /> | |||
| <LinearGradient id="area-background-gradient" from={background} to={background2} /> | |||
| <LinearGradient id="area-gradient" from={accentColor} to={accentColor} toOpacity={0.1} /> | |||
| <GridRows<number> | |||
There was a problem hiding this comment.
The generic type can be inferred from the input scale and this is no longer needed.
williaster
approved these changes
Aug 4, 2020
| /** `@vx/scale` or `d3-scale` object used to map from ScaleInput to y-coordinates. */ | ||
| scale: Scale<ScaleInput, number>; | ||
| scale: Scale; | ||
| /** Exact values used to generate grid coordinates (y- for Rows, x- for Columns) lines using `scale`. Overrides `numTicks` if specified. */ |
There was a problem hiding this comment.
should we remove the (y- for Rows, x- for Columns) piece here? also I think a leftover typo from me, could likely also remove the word coordinates here
| /** `@vx/scale` or `d3-scale` object used to map from ScaleInput to x-coordinates. */ | ||
| scale: Scale<ScaleInput, number>; | ||
| scale: Scale; | ||
| /** Exact values used to generate grid coordinates (y- for Rows, x- for Columns) lines using `scale`. Overrides `numTicks` if specified. */ |
There was a problem hiding this comment.
ditto re removing y- ... and x- from comment + removing coordinates
hshoff
approved these changes
Aug 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💥 Breaking Changes
Similar to
@vx/axisin #773 ,@vx/gridcomponents now accept D3 Scale as generic type instead ofScaleInput. Developers should not expect to specify this generic type as it can be inferred from the passed scale.