new(vx-xychart): add package boilerplate #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristw
approved these changes
Aug 18, 2020
| @@ -0,0 +1,11 @@ | |||
| import React from 'react'; | |||
| import { render } from 'react-dom'; | |||
| import ParentSize from '@vx/responsive/lib/components/ParentSize'; | |||
There was a problem hiding this comment.
Can this import from just @vx/responsive?
There was a problem hiding this comment.
yeah, but this is in the sandbox template / all of them are that way so would rather make a sweep to fix them all in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃殌 Enhancements
This adds the boilerplate code for a new
@vx/xychartpackage as part of the XYChart project.The package is marked as
privateso shouldn't be publishable, and I created an empty demo page which isn't linked to so its partial implementation shouldn't affect the demo site.@hshoff @kristw @techniq