Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A problem in your test method #2

Closed
mrchipset opened this issue Nov 13, 2018 · 1 comment
Closed

A problem in your test method #2

mrchipset opened this issue Nov 13, 2018 · 1 comment

Comments

@mrchipset
Copy link

Hello,
I think you make a mistake in your function return value arrange in Line 167. Your code is x, f, cost = beads(y=sig, d=d, fc=fc, r=r, lam0=lam0, lam1=lam1, lam2=lam2). But refer from the definition in Line 101, it should be x, cost, f = beads(y=sig, d=d, fc=fc, r=r, lam0=lam0, lam1=lam1, lam2=lam2).

@hsiaocy
Copy link
Owner

hsiaocy commented Nov 13, 2018

Yes, you are right!
In line 167, the test is not correct, and I will amend this, thank you!

@hsiaocy hsiaocy closed this as completed Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants