Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrading python-shell makes all logs appear "undefined" #101

Closed
johpiip opened this issue Jul 9, 2021 · 0 comments
Closed

Upgrading python-shell makes all logs appear "undefined" #101

johpiip opened this issue Jul 9, 2021 · 0 comments
Assignees
@johpiip

Comments

@johpiip
Copy link
Contributor

johpiip commented Jul 9, 2021 •
edited
Loading

Upgrading python-shell in package.json from ^1.0.8 to ^3.0.0 makes all log messages from helmet-model-system appear as: [undefined] undefined

Reproducing this issue:

  1. Change python-shell in package.json from ^1.0.8 to ^3.0.0.
  2. Run npm install and npm start.
  3. Run a model.
  4. The log looks like: 
    [UI-event] Initializing run of scenarios: test-helmet41
[undefined] undefined
[undefined] undefined
[undefined] undefined
[undefined] undefined
[undefined] undefined
[UI-event] Running scenario "test-helmet41"
[undefined] undefined
[undefined] undefined
[undefined] undefined
...
@johpiip johpiip self-assigned this Jul 9, 2021
@johpiip johpiip mentioned this issue Jul 9, 2021
Merged
johpiip added a commit that referenced this issue Aug 4, 2021
@johpiip
Bump python-shell from 1.0.8 to 3.0.0 and fix #101
7614070 
Logs from helmet-model-system were passed as dictionaries with
each character as its own value. See `src/main/index.js` for more
information. This might also be a bug in `python-shell` but it is difficult
to be sure so I fixed this myself.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johpiip johpiip

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@johpiip