Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove convenience wrapper functions for shock (size) arrival parameter #114

Merged
merged 14 commits into from Apr 4, 2024

Conversation

hsloot
Copy link
Owner

@hsloot hsloot commented Apr 3, 2024

Related issues

None

Checklist

  • R CMD CHECK successful
  • tests included
  • documentation included or updated
  • commit messages follow commit guidelines

Optional, but recommended:

  • code passes lintr::lint_package() without errors

Description

Proposed changes:

  • Remove convenience wrapper functions to create shock (size) arrival intensities for parametric families.
  • Keep as helpers for testthat
  • Move hierarchical parameter generator to testthat helpers

@hsloot hsloot self-assigned this Apr 3, 2024
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.85%. Comparing base (5dee7b8) to head (8df9675).

❗ Current head 8df9675 differs from pull request most recent head 52c100c. Consider uploading reports for the commit 52c100c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
+ Coverage   95.78%   95.85%   +0.07%     
==========================================
  Files          46       46              
  Lines        1399     1399              
==========================================
+ Hits         1340     1341       +1     
+ Misses         59       58       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hsloot hsloot force-pushed the depricate-parameter-helper branch from c69748e to 8df9675 Compare April 4, 2024 13:22
@hsloot hsloot merged commit 6e3272a into main Apr 4, 2024
11 checks passed
@hsloot hsloot deleted the depricate-parameter-helper branch April 4, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant