New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No attribute last_progress #106

Closed
hsoft opened this Issue Jun 22, 2013 · 5 comments

Comments

1 participant
@hsoft
Owner

hsoft commented Jun 22, 2013

@@@
Application Identifier: com.hardcoded_software.dupeguru_pe
Application Version: 1.10.0

Traceback (most recent call last):
File "core/app_cocoa_inter.pyc", line 130, in getJobProgress
AttributeError: 'ThreadedJobPerformer' object has no attribute 'last_progress'
@@@

@hsoft hsoft closed this Jun 22, 2013

@hsoft

This comment has been minimized.

Owner

hsoft commented Jun 22, 2013

After a quick glance at the code, this would technically only be possible when doing "Add iPhoto Library", which is the only place the the progress controller is shown before a job is created (when a job is created, last_progress is set). But for this to happen, there would need to be no last_progress leftover from the results loading when the app launched, which I think always happen. I'll investigate...

@hsoft

This comment has been minimized.

Owner

hsoft commented Jun 22, 2013

I don't get it. I can't understand how it's possible to go through the initialization phase (load results) without ending up with last_progress set to something. It's strange that I had 2 of these reports one after the other, shortly after I released the Python 3 based versions of DG (when I never received such reports before). I'm still waiting on feedback from users who reported this. Meanwhile, I'll have to put this on hold.

@hsoft

This comment has been minimized.

Owner

hsoft commented Jun 22, 2013

@hsoft

This comment has been minimized.

Owner

hsoft commented Jun 22, 2013

Oops, I didn't wrap everything...

@@@
Application Identifier: com.hardcoded_software.dupeguru_pe
Application Version: 1.11.1

Traceback (most recent call last):
File "core/app_cocoa_inter.pyc", line 149, in getJobDesc
AttributeError: 'ThreadedJobPerformer' object has no attribute 'last_desc'
@@@

@hsoft

This comment has been minimized.

Owner

hsoft commented Jun 22, 2013

(from [a3ca4aef6713]) [#106 state:fixed] Wrapped getJobDesc in a try except in case it isn't defined yet.
http://bitbucket.org/hsoft/dupeguru/changeset/a3ca4aef6713/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment