None items in results causing crashes. #140

Closed
hsoft opened this Issue Jun 22, 2013 · 8 comments

Projects

None yet

1 participant

@hsoft
Owner
hsoft commented Jun 22, 2013

I got 3 crash reports caused by None results in a row. Strange.

@@@
Application Identifier: com.hardcoded_software.dupeguru_pe
Application Version: 2.0.0

Traceback (most recent call last):
File "/Applications/dupeGuru PE.app/Contents/Resources/dg_cocoa.plugin/Contents/Resources/dg_cocoa.py", line 27, in getSelectedDupeRefPath
File "core_pe/app_cocoa.pyc", line 210, in selected_dupe_ref_path
AttributeError: 'NoneType' object has no attribute 'path'
@@@

@@@
Application Name: dupeGuru Picture Edition
Version: 1.11.3

Traceback (most recent call last):
File "/usr/local/share/dupeguru_pe/qt/base/main_window.py", line 321, in detailsTriggered
self.app.show_details()
File "/usr/local/share/dupeguru_pe/qt/base/app.py", line 179, in show_details
self.details_dialog.show()
File "/usr/local/share/dupeguru_pe/qt/pe/details_dialog.py", line 95, in show
self._update()
File "/usr/local/share/dupeguru_pe/qt/pe/details_dialog.py", line 72, in _update
self.referencePixmap = QPixmap(str(ref.path))
AttributeError: 'NoneType' object has no attribute 'path'
@@@

@@@
Application Name: dupeGuru Picture Edition
Version: 2.0.0

Traceback (most recent call last):
File qt\base\result_window.py, line 263, in detailsTriggered File qt\base\app.py, line 203, in show_details File qt\pe\details_dialog.py, line 96, in show File qt\pe\details_dialog.py, line 73, in _updateAttributeError: 'NoneType' object has no attribute 'path'

@hsoft hsoft closed this Jun 22, 2013
@hsoft
Owner
hsoft commented Jun 22, 2013

I got two new ones from dgpe (cocoa version) 2.0.0

It seems to be specific to PE.

@hsoft
Owner
hsoft commented Jun 22, 2013

More details from a user (who had the same crash, pe_cocoa 2.0.0):

I had scanned, and then selected "Dupes Only". I then moved the dupes to a new location using the dropdown menu. The error occurred when I tried to switch back to "Details". The app kept running in spite of the error. The scan was of files on a USB drive attached to my AirPort Extreme Base Station, if that matters.

@hsoft
Owner
hsoft commented Jun 22, 2013

(from [245fcaf252fc]) [#140 state:fixed] Fixed a crash on showing details panel in PE right after a mark-based removal (selection wasn't refreshed).
https://bitbucket.org/hsoft/dupeguru/changeset/245fcaf252fc/

@hsoft
Owner
hsoft commented Jun 22, 2013

For the record, this error is not specific to PE. It also happens if you use Make Selected Reference right after an action that removes marked dupes.

@hsoft
Owner
hsoft commented Jun 22, 2013

Well, gotta re-open the ticket because I got a couple of more crash report for pe2.1.0. A lot of them seem to be related to dupe renaming.

@@@
Application Identifier: com.hardcoded_software.dupeguru_pe
Application Version: 2.1.0

Traceback (most recent call last):
File "core/app_cocoa_inter.pyc", line 202, in renameSelected_
File "core/gui/result_table.pyc", line 105, in rename_selected
AttributeError: 'NoneType' object has no attribute '_data'
@@@

@@@
Application Identifier: com.hardcoded_software.dupeguru_pe
Application Version: 2.1.0

Traceback (most recent call last):
File "core/app_cocoa_inter.pyc", line 156, in jobCompleted_
File "core/app.pyc", line 116, in _job_completed
File "core/app.pyc", line 109, in _results_changed
File "hscommon/notify.pyc", line 19, in notify
File "hscommon/notify.pyc", line 52, in dispatch
File "core/gui/result_table.pyc", line 151, in results_changed
File "core/gui/result_table.pyc", line 89, in refresh_with_view
File "hscommon/gui/table.pyc", line 257, in refresh
File "hscommon/cocoa/inter.pyc", line 55, in refresh
File "core/app_cocoa_inter.pyc", line 202, in renameSelected

File "core/gui/result_table.pyc", line 105, in rename_selected
AttributeError: 'NoneType' object has no attribute '_data'
@@@

The two above seem to be related. From two different users, I got these two reports, one after the other (within a minute of each other)

@@@
Application Identifier: com.hardcoded_software.dupeguru_pe
Application
Version: 2.1.0

Traceback (most recent call last):
File "hscommon/cocoa/init.pyc", line 53, in _async_run
File "core_pe/app_cocoa.pyc", line 162, in _do_delete
File "core/results.pyc", line 244, in perform_on_marked
File "core_pe/app_cocoa.pyc", line 150, in op
File "core_pe/app_cocoa.pyc", line 168, in _do_delete_dupe
AttributeError: 'NoneType' object has no attribute 'photos'
@@@

oh, and also me6.0.1

@@@
Application Name: dupeGuru Music Edition
Version: 6.0.1

Traceback (most recent call last):
File "/usr/local/share/dupeguru_me/qt/base/results_model.py", line 80, in setData
return self.model.rename_selected(value)
File "/usr/local/share/dupeguru_me/core/gui/result_table.py", line 105, in rename_selected
row._data = None
AttributeError: 'NoneType' object has no attribute '_data'
@@@

@hsoft
Owner
hsoft commented Jun 22, 2013

I could reproduce the error by initiating a rename and then, while the edit box is visible, remove the selected row from results.

@hsoft
Owner
hsoft commented Jun 22, 2013

Also: the report on PE 2.1.0 that has nothing to do with renaming is somewhat of a mystery, but since I only received one of these reports, I'll let it slide and ask for more details in the next report.

@hsoft
Owner
hsoft commented Jun 22, 2013

(from [ceb5ae1bdfc3]) [#140 state:fixed] Fixed a crash on dupe renaming.
https://bitbucket.org/hsoft/dupeguru/changeset/ceb5ae1bdfc3/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment