Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable symlink/hardlink radio buttons in deletion options #247

Closed
ghost opened this issue Nov 24, 2013 · 1 comment
Closed

Disable symlink/hardlink radio buttons in deletion options #247

ghost opened this issue Nov 24, 2013 · 1 comment
Labels
bug Bug reports.

Comments

@ghost
Copy link

ghost commented Nov 24, 2013

from email:

I have just bought DupeGuru and would suggest that there is an important interface design error that caused me to delete many duplicates without creating links to the original when in fact I had selected the 'hardlink' radio button.

I suggest that the link radio buttons (Symlink and Hardlink) are dimmed and only made active once the "Link deleted files" checkbox is selected. This would prevent me from thinking I had asked for links when in fact I have only changed the radio button choice.
@ghost
Copy link
Author

ghost commented Dec 6, 2013

Note: This behavior has to be adjusted on both Qt and Cocoa.

@ghost ghost self-assigned this Dec 6, 2013
ghost pushed a commit that referenced this issue Dec 6, 2013
Disable symlink/hardlink option when not relevant (Qt)
cb8bb5a 
When the "Replace with links" option is not enabled, the choice of
symlink or hardlink is irrelevant and causes confusion. Implemented core
mechanism for controlling the enabled state of that option. Also
implemented the Qt interface for it. Cocoa-part is still to be done.

I used this opportunity to greatly enhance documentation of this part of
the code. I'm beginning to like documenting...

Ref #247.
@ghost ghost closed this as completed in d14d076 Dec 7, 2013
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Bug reports.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0 participants