Disable symlink/hardlink radio buttons in deletion options #247

hsoft opened this Issue Nov 24, 2013 · 1 comment


None yet

1 participant

hsoft commented Nov 24, 2013

from email:

I have just bought DupeGuru and would suggest that there is an important interface design error that caused me to delete many duplicates without creating links to the original when in fact I had selected the 'hardlink' radio button.

I suggest that the link radio buttons (Symlink and Hardlink) are dimmed and only made active once the "Link deleted files" checkbox is selected. This would prevent me from thinking I had asked for links when in fact I have only changed the radio button choice.

hsoft commented Dec 6, 2013

Note: This behavior has to be adjusted on both Qt and Cocoa.

@hsoft hsoft was assigned Dec 6, 2013
@hsoft hsoft added a commit that referenced this issue Dec 6, 2013
@hsoft Disable symlink/hardlink option when not relevant (Qt)
When the "Replace with links" option is not enabled, the choice of
symlink or hardlink is irrelevant and causes confusion. Implemented core
mechanism for controlling the enabled state of that option. Also
implemented the Qt interface for it. Cocoa-part is still to be done.

I used this opportunity to greatly enhance documentation of this part of
the code. I'm beginning to like documenting...

Ref #247.
@hsoft hsoft closed this in d14d076 Dec 7, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment