Custom Image

[kyominoh]

Hi, bro

I have a problem with RatingView that u posted on Github.

I applied the following source to use a different image, not the existing star image, as you wrote.

starRatingView.emptyStarImage = [UIImage imageNamed:@"heart-empty"]; //like_off_big.png
starRatingView.filledStarImage = [UIImage imageNamed:@"heart-full"];//like_on_big.png

I could see the new image that I put in on RatingView, but when I tried to run RatingView, apps crash. (touched RatingView)

The reason for the crash is

[UIImage renderingMode]: message sent to deallocated instance

I used call stack and figured out the following code occurred the error.

[self _drawStarWithFrame:frame tintColor:self.tintColor highlighted:highlighted]; in drawRect:(CGRect)rect

Could you please let me know how to solve this problem?

Thank you.

[kyominoh]

i try to storyboard, but apps are crash

sorry my eng

[hsousa]

Hi @kyominoh!

I find that very strange, because those properties are strong.

Can you share a simple sample project where that happens? (you can zip it and paste the dropbox link here)

[kyominoh]

https://www.dropbox.com/s/7qwa133kmjmx2xd/KKariPeopleFixMe.zip?dl=0

Here is a simple source
Full source can not share, sorry
And Sorry to bother

[hsousa]

The problem is that you're not using ARC, so when you do this:

_ratingView.filledStarImage = [[UIImage imageNamed:@"like_off_big"] imageWithRenderingMode:UIImageRenderingModeAlwaysTemplate];

I'm doing this:

- (void)setFilledStarImage:(UIImage *)filledStarImage {
    if (_filledStarImage != filledStarImage) {
        _filledStarImage = filledStarImage;
        [self setNeedsDisplay];
    }
}

As you can see, my code is ARC-only (ie. I'm not retaining anything because ARC does that for me) and you just provided that setter an autoreleased object. That means that the object will get released on the next runloop, resulting in the error you're seeing.

My advice is to get on the ARC boat, since it's awesome... but if you must stay away from ARC, add the -fobjc-arc flag to HCSStarRatingView.m so at least that gets compiled with ARC enabled.

Please note that you will have the exact same type of problems if you use a lot of other controls from GitHub, since almost all of them require ARC nowadays (but you can definitely use the flag approach above for other controls).

For reference, this is where you need to add the flag:

[kyominoh]

Thanks Bro,
I forgot to develop again in two years
i'm fool ㅠ.ㅠ

[hsousa]

No worries man, glad I could help. 👍

[kyominoh]

thanks shared source
Very well've used them
Good luck