Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voting when unauthenticated resolves in 401 and no visible change in the UI 🤔 #3

Open
flowsn4ke opened this issue Nov 16, 2020 · 1 comment

Comments

@flowsn4ke
Copy link

flowsn4ke commented Nov 16, 2020

Hi Harry!

I just saw the release video and tried out the website! It's looking great but on thing I noticed is that when one tries to vote while not being authenticated, there's no visual cue in the UI, I had to crack open the console to see I was getting back a 401...

I think a nice modal like they have at https://9gag.com/ when you try to vote unauthenticated would solve that, basically it's the same modal that they use for signup...

I'm guessing you could just reuse the sign in / sign up component and get it to show up when trying to vote unauthenticated? Not entirely sure how to get that done though (or how to even propose changes on GitHub for that matter), it's actually my first issue request, like, ever 😁

P.S.: Great app you've got here, I will definitely buy the tutorial when you make it 😉

@hswolff
Copy link
Owner

hswolff commented Nov 17, 2020

Incredible! First issue! I love it!

And yes, I agree! This would be a lovely enhancement to add! I may do something cheaper to start off with, but what you propose sounds like a great end state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants