Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unchanged files marked as modified #160

Closed
annitya opened this issue Aug 12, 2015 · 8 comments
Closed

Unchanged files marked as modified #160

annitya opened this issue Aug 12, 2015 · 8 comments
Milestone

Comments

@annitya
Copy link

annitya commented Aug 12, 2015

Hi!

This plugin seems to mark non-project files as modified in some subtle way.
They do not show up in changes-views of in version-control, but "close unmodified" no longer works while the plugin is active.

@hsz
Copy link
Member

hsz commented Aug 12, 2015

Can you provide more information / screenshots ?

@annitya
Copy link
Author

annitya commented Aug 12, 2015

I've had a hard time narrowing it down, but I finally got it now.
If a file is open from a directory which is listed in a .gitignore-file it will appear grayed out like so:

image

The file in question will then not be touched by "close unmodified".

@hsz
Copy link
Member

hsz commented Aug 12, 2015

IntelliJ also doesn't close files that are ignored with Version Control > Ignored Files too - for example:

.idea/workspace.xml

If you open it (without enabled .ignore plugin) it has yellow color. Close unmodified action is not perdormed on this file.

What do you think about new feature like Close ignored action ?

@annitya
Copy link
Author

annitya commented Aug 12, 2015

The plugin is currently disabled, but I was unable to reproduce the behaviour you describe.
I tried first with an entire directory, then with a specific file. All files where closed as expected.

I'm currently running PhpStorm 9.0 btw.

My use of .gitignore-files are very simplistic, so I think I will leave the plugin disabled for now.

"Close unmodified" is unbound by default, and this issue has been present for several months now.
I think you can close this issue, as I find it unlikely that anyone else will experience it.

@hsz
Copy link
Member

hsz commented Aug 12, 2015

Quick showcase about the IntelliJ behaviour with natively ignored files:

Custom ignored.txt ignore rule:
image

IntelliJ marks ignored files with yellow color:
image

Closing unbodified files leaves ignored.txt opened
image
image

So without breaking IntelliJ logic I can provide extra Close Ignored option which will close all grayed files.

@annitya
Copy link
Author

annitya commented Aug 12, 2015

If it is a setting that could be enabled it would definitely work for me! :)

@hsz
Copy link
Member

hsz commented Aug 12, 2015

Ok, feature will be available with the next release. Sneak peek:

image

@hsz hsz added this to the 1.2 milestone Aug 12, 2015
@annitya
Copy link
Author

annitya commented Aug 12, 2015

Thanks! :)

hsz added a commit that referenced this issue Aug 12, 2015
@hsz hsz closed this as completed Aug 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants