Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling of multi module project with parent and children in separate git repos #383

Closed
leonroy opened this issue Jun 29, 2017 · 3 comments

Comments

@leonroy
Copy link

leonroy commented Jun 29, 2017

I have a multi module IntelliJ project which looks like:

my-app
├── pom.xml
├── .gitignore
├── auth-server
│   └── src/main/java
│   └── pom.xml
│   └── .gitignore
├── api-server
│   └── src/main/java
│   └── pom.xml
│   └── .gitignore
└── web-client
    └── src/main/js
    └── src/main/css
    └── pom.xml
    └── .gitignore

Parent is a Java project with a couple of child modules.

The parent .gitignore obviously ignores the child modules already in their own git repos so I'm not committing them twice:

ie.

api-server/
auth-server/
web-client/

The .ignore plugin throws up You are editing file which is ignored for any child module source code even though the child git repo is different to the parent's and hence should not inherit the parent .gitignore rules.

  • How should the plugin be handling this scenario?
  • Is there any sort of work around?
@leonroy leonroy changed the title Handling of multi module project with parent and children in separate git modules Handling of multi module project with parent and children in separate git repos Jun 29, 2017
@bradacjan
Copy link

bradacjan commented Jul 16, 2017

I have a simillar issue, where the modules are symlinked to a parent project for convenience .
And after updating PhpStorm and the .gitignore plugin, I get the extremely annoying popup "You are editing file which is ignored".

It would be great if it was possible to disable the popup in settings (for people who run into scenarios like this).

The entire filename and tab name are grayed out, that is more than enough to notice that I am editing an ignored filename. And PhpStorm already alerts you if you are editing files outside of project scope. So the popup seems redundant to me.

I really like your plugin and would love to keep using it. It is very helpful and has been nicely unobtrusive so far. I would have loved it to stay that way.

Update:
For anyone who struggles the popup as well - you can quickly dismiss it using only keyboard by pressing alt+enter and then enter again. That makes it a lot less annoying.

@hsz
Copy link
Member

hsz commented Jul 30, 2017

@bradacjan You can disable this You are editing file which is ignored message in the plugin's settings:

image

@bradacjan
Copy link

Great, that works. I could not find that before, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants