Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin not compatible on latest Intellij EAP #408

Closed
SUPERCILEX opened this issue Aug 3, 2017 · 52 comments
Closed

Plugin not compatible on latest Intellij EAP #408

SUPERCILEX opened this issue Aug 3, 2017 · 52 comments

Comments

@SUPERCILEX
Copy link

EAP info:

IntelliJ IDEA 2017.2.2 EAP
Build #IU-172.3757.5, built on August 1, 2017

Error message:

Plugin Error
Problems found loading plugins:
The following plugins are incompatible with the current IDE build: .ignore
@treasure33
Copy link

I have the same problem.
Gogland (1.0 Preview) 1.0 EAP Build #GO-172.3757.2, built on August 1, 2017
Version: 2.0.4

@fa1com
Copy link

fa1com commented Aug 5, 2017

same issue here, eagerly asking for an update

@thaJeztah
Copy link

Wondering if it's just due to this; https://github.com/hsz/idea-gitignore/blob/9c534e64ceb145b14bc1e0d214d2a7c3ad0ee891/resources/META-INF/plugin.xml#L113

Starting with 2016.2 the build number may also have multiple components: IU-162.94, IU-162.94.11, IU-162.94.11.256.42. This gives more flexibility for third-party plugins and IDE developers. Plugins may specify compatibility versions more precisely; IDE vendors may have build numbers that are based on a specific IntelliJ Platform version and also specify additional internal version (e.g. 256.42 in XX-162.94.11.256.42) to allow plugin developers for their IDE to specify compatibility.

http://www.jetbrains.org/intellij/sdk/docs/basics/getting_started/build_number_ranges.html

@jwfearn
Copy link

jwfearn commented Aug 7, 2017

Also seeing this issue with this configuration:
IntelliJ IDEA 2017.2.2 EAP
Build #IU-172.3757.5, built on August 1, 2017
JRE: 1.8.0_152-release-915-b10 x86_64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Mac OS X 10.12.6

@qJkee
Copy link

qJkee commented Aug 9, 2017

Same problem

@solcates
Copy link

solcates commented Aug 9, 2017

same here, missing .ignore :(

@thaJeztah
Copy link

thaJeztah commented Aug 9, 2017

Just stating the obvious (I personally don't have experience with developing IntelliJ, but if someone here has); this plugin is open source - the author most likely maintains it in his spare time. contributions are welcome so if this plugin is essential for your day-to-day work, and you have some time to spare; open a pull request 👍

@Kurre
Copy link

Kurre commented Aug 10, 2017

Updating the version constraint to since-build="162" (or removing it altogether) will fix the situation.

On META-INF/plugin.xml file
https://github.com/hsz/idea-gitignore/blob/9c534e64ceb145b14bc1e0d214d2a7c3ad0ee891/resources/META-INF/plugin.xml#L113

But I need to monitor that everything is in working order.
Dunno what would be the correct way to handle this..maybe that <idea-version since-build="162"/> would be fine?

edit: Okay, so I had manually changed the plugin version, so actually that was the reason it worked for me..happened so automatically, I didn't remember to mention it.. 😮

@Adev24
Copy link

Adev24 commented Aug 10, 2017

PhpStorm 2017.2.2 EAP (172.3757.34) same problem
updating/deleting <idea-version ...> not help

@hsz hsz added the bug label Aug 10, 2017
@hsz hsz added this to the v2.0.5 milestone Aug 10, 2017
@hsz
Copy link
Member

hsz commented Aug 10, 2017

Ok, it appears that v2.0.4 has been blacklisted in the latest IntelliJ code build:

https://github.com/JetBrains/intellij-community/blob/172.3861/platform/platform-resources/src/brokenPlugins.txt#L33

mobi.hsz.idea.gitignore 1.2 1.3 1.3.3 1.4.1 1.5 1.6 1.7.5 1.7.6 2.0.4

Commit ref:

JetBrains/intellij-community@c8c4800

Looks like it will be automatically fixed with the next bumped version number.

CC:
@drealecs @dcarbone @filiphr @BorzdeG @Caravus @jwfearn @justinlynn @msadakov @Kendos-Kenlen @liayn @gl3b4ik @Scott-G @potto007 @Kurre @SUPERCILEX @treasure33 @MerlinPong @thaJeztah @jwfearn @qJkee @solcates @F21 @favadi @damagedcode @dexterHD @cbednarski @Scratch-net @msadakov @npiganeau @klauern @zhezh09 @Badbits @michael1011 @damagedcode

@filiphr
Copy link

filiphr commented Aug 10, 2017

Thats great. Does someone know why they would do that?

I know that the issue with the indexing was pretty bad, but it was fixed in 2.x as far as I remember.

@hsz
Copy link
Member

hsz commented Aug 10, 2017

@nicity Can you explain us, what's the policy of blacklisting the plugin versions?

@nicity
Copy link

nicity commented Aug 10, 2017

We get too many user reports about users having performance problems with .gitignore plugin.
Even latest plugin version has such performance problems.
Our current plan is to disable all available plugin versions until there is one without performance problems.
Good news is that we can help to make proper implementation.
E.g. nothing should be done during processing virtual file events, IgnoreFileIndex.getKeys() should not be called from mobi.hsz.idea.gitignore.IgnoreManager.isFileIgnored(VirtualFile), etc

@hsz
Copy link
Member

hsz commented Aug 11, 2017

@nicity thank you for the response!

Can you share with me the details about all problems that you have noticed (thread dumps, stack traces, good practices)?
In what way can you help me with the proper implementation?

@nicity
Copy link

nicity commented Aug 11, 2017

Let's start with #415

@zman0900
Copy link

Just adding that IntelliJ 2017.2.2 was released today and the plugin continues to be blocked:

6:32 PM	Plugin Error
				Problems found loading plugins:
				The following plugins are incompatible with the current IDE build: .ignore

@tong12580
Copy link

@zman0900 so am i

@hsz
Copy link
Member

hsz commented Aug 21, 2017

@robert-cody This warning about tracked files is already reported and will be fixed with #400

@BorzdeG
Copy link

BorzdeG commented Aug 21, 2017

works on Mac OS:

IntelliJ IDEA 2017.2.3 EAP
Build #IU-172.3968.1, built on August 15, 2017
JRE: 1.8.0_152-release-915-b10 x86_64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Mac OS X 10.12.6

@hsz hsz modified the milestones: v2.1.0, v2.1.0-RC.1 Aug 21, 2017
@ghost
Copy link

ghost commented Aug 21, 2017

EAP works for me

@fengcen
Copy link

fengcen commented Aug 21, 2017

"hide ignored files" not work

This was referenced Aug 21, 2017
@Scott-G
Copy link

Scott-G commented Aug 21, 2017

Seems fine here. Thanks for your efforts.

PhpStorm 2017.2.2 EAP
Build #PS-172.3757.60, built on August 16, 2017
JRE: 1.8.0_152-release-915-b10 amd64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Windows 10 10.0

@justinlynn
Copy link

justinlynn commented Aug 22, 2017

hmm, on 2017.2.3 EAP (latest) the RC.1 version does not properly re-hide files at the top-level in the Project explorer when show/hide ignored files is toggled from the right-click context menu (no exception is thrown). Also, there is no "{n} hidden" notation at top-level even when files are hidden on IDE start. However, if you edit the top-level .gitignore file and save it -- it works as expected (except if one adds a top-level directory, in which was all subpaths are hidden but not the top-level entry).

Additionally, new version does not pick up global ignore file set with core.excludesfile git configuration setting.

Otherwise it appears to work quite well.

@hsz would you prefer I file separate bugs for the two issues outlined above re the RC?

@xrhou
Copy link

xrhou commented Aug 22, 2017

2017/8/22
2017.2.2 stable release
mac osSierra 10.12.6
oracle java version "1.8.0_131"
Java(TM) SE Runtime Environment (build 1.8.0_131-b11)
Java HotSpot(TM) 64-Bit Server VM (build 25.131-b11, mixed mode)

IDEA error
上午8:28 Plugin Error
Problems found loading plugins:
The following plugins are incompatible with the current IDE build: .ignore

@hsz
Copy link
Member

hsz commented Aug 22, 2017

@fengcen @justinlynn Thanks.

Can you please check if those bugs were fixed for you with v2.1.0-RC.2 ?

@fengcen
Copy link

fengcen commented Aug 22, 2017

@hsz Sometimes not work. Steps to reproduce:
Install Rust plugin, restart, or uninstall Rust plugin, restart.
I try it on windows.

@hsz hsz closed this as completed Aug 22, 2017
@hsz
Copy link
Member

hsz commented Aug 22, 2017

New version v2.1.0 has been released just right now.

@justinlynn
Copy link

@hsz apologies. I've installed the v2.1.0 plugin. Most of the issues have been addressed; however, on 2017.2.3 RC3, I now note that it appears that the entries that the plugin has trouble with are all globbed entries (for example "*.pdf"). Once the glob is removed things work as expected. Once I can get a minimal test case I'll file a new issue. Much faster! Great work!

@hsz
Copy link
Member

hsz commented Aug 23, 2017

@justinlynn Thanks!

Did you notice any of #450 or #414 ? They're not reproducible for me, unfortunately.

@justinlynn
Copy link

justinlynn commented Aug 23, 2017

@hsz negative, no exceptions thrown by the plugin as of yet on 2017.2.3 RC3 on Linux -- will comment on ticket if I can see that. Any chance of getting exception reporting (similar to Jetbrains core exception reporting) working -- might make things easier? I don't know what might be involved in that though.

@york-xtrem
Copy link

I am installing from the zip in mac osx (intellij IDEA 2017.2.2) and I get this error:

Fail to load plugin descriptor from file idea-gitignore-2.1.0.zip

Since the plugin searcher does not appear yet

@F21
Copy link

F21 commented Aug 23, 2017

@york-xtrem I was able to install it using the plugin manager by following these directions: https://github.com/hsz/idea-gitignore#early-access-preview-repository-channel

@hsz
Copy link
Member

hsz commented Aug 23, 2017

@york-xterm I had to remove this version from JB repo because of above errors. I'm on it right now.

@york-xtrem
Copy link

york-xtrem commented Aug 23, 2017

@F21 and @hsz apologize for ignorance! It is already installed, I have tried it in several projects and it works to me as expected ;)

@bamapookie
Copy link

Using 2.1.1 on

IntelliJ IDEA 2017.2.3
Build #IU-172.3968.16, built on August 21, 2017
JRE: 1.8.0_152-release-915-b11 x86_64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Mac OS X 10.12.6

Confirm no issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests