Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix non-standard static library name #952

vapier opened this issue Jun 4, 2021 · 1 comment

fix non-standard static library name #952

vapier opened this issue Jun 4, 2021 · 1 comment


Copy link

vapier commented Jun 4, 2021

the shared library is installed as (e.g. on UNIX) which is good, but for some reason the static library name is changed to libtidys.a. this is not standard library behavior and seems entirely unnecessary. can the s be dropped so normal linkage works ?

Copy link

It looks like this was a Windows-driven deliberate decision way back in efb8e37 (2015).

Due mainly to windows where the static and shared libraries have the same
name, appended an 's' to the static library.

Sure enough, when I build on Windows, I see something call tidy.lib, so there's obviously a conflict. I'm not a Windows programmer, but the best I could come up with is that Windows needs some type of stupid "stub" file that references the actual dynamic library, so it looks like we're stuck with it.

@vapier, I see in the CMakeLists.txt where it would be trivial to define a "proper" name (sans s) for everything but Windows, but I'd really like to try to keep things consistent across platforms, if possible. In what ways is the added s an actual problem? What about it being "non-standard" is the issue? Does your linker automatically assume tidy.h has a tidy.lib in the library path, and you're forced to correct it?

If so, that's good enough for me, but I don't want to assume things before I make a change; I need to understand that there's actually a problem that this would solve before making the (trivial) change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

No branches or pull requests

2 participants