Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build and document strategy for testing with identity providers #3

Closed
tonysurma opened this issue Jul 20, 2015 · 6 comments
Closed

Comments

@tonysurma
Copy link
Member

as mentioned in the readme the keys for the identify providers will be secrets that are configured in deployment for testing and production.

We need a strategy for how individual contributors can test with identity providers without sharing the 'secret' codes from deployment in production.

@TimHess
Copy link

TimHess commented Aug 8, 2015

I'd like to help with this one

@bcbeatty
Copy link
Contributor

bcbeatty commented Oct 7, 2015

Do you need to provide the secretKey for a facebook login? On another app I'm working on I'm not using the secretKey just the AppId, which is public. But I'm still running on local emulators.
Ionic has OpenId Providers as part of its framework.

@bcbeatty
Copy link
Contributor

bcbeatty commented Oct 7, 2015

Here's javascript code snip it for facebook login using cordovaOauth

 $cordovaOauth.facebook(appKeys.appId, ["email", "user_friends, user_location, user_posts, user_photos"]).then(function (result) {
                    console.info("login success");
                    $localStorage.accessToken = result.access_token;

                    q.resolve($localStorage.accessToken);
                }, function (error) {                 
                    console.error(error);
                    alert("There was a problem signing in!  See the console for logs\n" + error);
                    q.reject(error);
                });
 return q.promise;

@MisterJames
Copy link
Contributor

@tonysurma I think an easy strategy here would be to include a quick readme for setting this up. UserSecrets is pretty easy to get going. I could write this.

They would need to, of course, create their own apps/app secret keys to make this work, but that isn't an insurmountable task.

@tonysurma
Copy link
Member Author

great thanks!

@tonysurma tonysurma modified the milestones: November Codeathon, Complete Initial Ownership Transition Oct 13, 2015
@MisterJames MisterJames added the P3 label Oct 31, 2015
BillWagner pushed a commit that referenced this issue Nov 2, 2015
BillWagner pushed a commit that referenced this issue Nov 7, 2015
Sync up with recent merges
BillWagner pushed a commit that referenced this issue Nov 7, 2015
Task edit/create with command/query
BillWagner pushed a commit that referenced this issue Nov 7, 2015
Bring local fork to latest code
@BillWagner
Copy link
Member

I believe this has been addressed by the work where we implemented the 3rd party OAuth work. Can @MisterJames or @tonysurma re-open if I'm mistaken.

MisterJames pushed a commit that referenced this issue May 12, 2016
tonysurma pushed a commit that referenced this issue Dec 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants