Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 8.2.0 introduced a bug with deprecated tags option #253

Closed
KillyMXI opened this issue Jul 6, 2022 · 2 comments
Closed

Version 8.2.0 introduced a bug with deprecated tags option #253

KillyMXI opened this issue Jul 6, 2022 · 2 comments

Comments

@KillyMXI
Copy link
Member

KillyMXI commented Jul 6, 2022

Not asking for a change but this patch broke the typescript type definitions test. The test has no format specified:

    tags: {
        a: {
            options: {
                hideLinkHrefIfSameAsText: true,
                linkBrackets: ["[", "]"],
            },
        },

This results in Error: Following selectors have no specified format: 'a'

It previously worked with the default format getting merged but that does not happen now. Also noting that in handleDeprecatedOptions there are a number of checks for the format value that may not have been set yet. Maybe needed a second call to mergeDuplicatesPreferLast after pushing all the tags to selectors.

Originally posted by @webstech in #249 (comment)

@KillyMXI
Copy link
Member Author

KillyMXI commented Jul 6, 2022

@webstech Thank you.
I was going to keep the tags option in another version as it was deprecated relatively recently.
So I'm going to address this in the next version (whatever that happens to be).
The bug is currently present both in the master (v8) and in v9 branch.
I should keep more tests for deprecated options.

@KillyMXI
Copy link
Member Author

KillyMXI commented Dec 3, 2022

I had to fix the issue with tags twice. It should work as intended now in version 9.
To be finally removed in version 11, most likely.

@KillyMXI KillyMXI closed this as completed Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant