Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot see password in Forms while field required (icon overlaps) + see icon not working in chrome #103

Open
gbrault opened this issue Oct 5, 2023 · 0 comments

Comments

@gbrault
Copy link

gbrault commented Oct 5, 2023

Describe the bug

  • The smart-password-text-box overlaps with the Ok or Ko icon in all browers while used in a form
  • In Chrome, the see icon don't allows to actually see the password

To Reproduce

<body class="viewport">
        <div class="smart-grid-layout">
            <div class="row">
                <div class="col-sm-4"></div>
                <div class="col-sm-4">
                    <smart-card class="basic-card" style="width: fit-content;">
                        <div class="card-content" style="padding: 1% 1% 1% 1%;">
                            <h1  class="card-title">Sign In to SeaDev.xyz dev</h1>
                            <div class="smart-form-row">
                                <form id="signInForm" onsubmit="return false;">
                                    <div class="smart-form-row">
                                        <label>
                                            User Name:
                                        </label>
                                        <smart-input class="underlined" form-control-name="userName" id="userName"></smart-input>
                                    </div>

                                    <div class="smart-form-row">
                                        <label>
                                            Password:
                                        </label>
                                        <smart-password-text-box class="underlined" form-control-name="Password" id="Password"></smart-password-text-box>
                                    </div>

                                    <div class="smart-form-row submit">
                                        <smart-button class="success" form-control-name="submit" type="submit" onClick="auth()">Submit</smart-button>
                                    </div>
                                </form>
                            </div>
                        </div>
                    </smart-card>
                </div>
                <div class="col-sm-4"></div>
            </div>
        </div>
        <script type="module" src="/source/modules/smart.form.js"></script>
        <script type="module" src="/source/modules/smart.input.js"></script>
        <script type="module" src="/source/modules/smart.button.js"></script>
        <script type="module" src="/source/modules/smart.validator.js"></script>
        <script type="module" src="/source/modules/smart.passwordtextbox.js"></script>
        <script type="module" src="/source/modules/smart.card.js"></script>
</body>

Expected behavior

  • Ability to have the required icon and the see icon active (they overlap)
  • Clicking on see (which is always overlapped on any browser)
    • don't work (Chrome): i.e. clecking on see icon don't show password
    • works on Firefox and Edge
      Screenshots
      You can see the see icon rigth behind the green check (very small)
      image

Desktop (please complete the following information):

  • OS: [e.g. iOS]: Windows 11
  • Browser
    • Chrome Version 117.0.5938.150 (Build officiel) (64 bits)
    • Edge Version 117.0.2045.55 (Version officielle) (64 bits)
    • Firefox 118.0.1 (64 bits)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant