Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data-hs-overlay-keyboard is not working #290

Closed
gkcsabado opened this issue Feb 26, 2024 · 2 comments
Closed

data-hs-overlay-keyboard is not working #290

gkcsabado opened this issue Feb 26, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@gkcsabado
Copy link

Setting the data-hs-overlay-keyboard to true doesn't prevent the Esc button to close the modal.

function QuoteForm() {
  const totalSteps = 8;
  const [currentStep, setCurrentStep] = useState(1);

  ...

  return (
    <>
      <div
        id="QuoteFormModal"
        className="hs-overlay hidden w-full h-full fixed top-0 start-0 z-[80] overflow-x-hidden overflow-y-auto pointer-events-none [--overlay-backdrop:static]"
        data-hs-overlay-keyboard="true"
      >
        <div className="hs-overlay-open:mt-0 hs-overlay-open:opacity-100 hs-overlay-open:duration-500 mt-10 opacity-0 transition-all w-full max-w-full fixed md:static bottom-0 md:hs-overlay-open:mt-10 md:mt-0 md:max-w-lg md:mx-auto">
          <div className="flex flex-col bg-white md:border rounded-t-xl md:rounded-b-xl pointer-events-auto md:shadow-sm">
            <div className="px-6 md:px-10">
              <ProgressBar
                currentStep={currentStep}
                totalSteps={totalSteps}
              />

              {renderStep()}
            </div>
          </div>
        </div>
      </div>
    </>
  );
}

export default QuoteForm;
@olegpix
Copy link
Collaborator

olegpix commented Feb 28, 2024

Setting the data-hs-overlay-keyboard to true doesn't prevent the Esc button to close the modal.

function QuoteForm() {
  const totalSteps = 8;
  const [currentStep, setCurrentStep] = useState(1);

  ...

  return (
    <>
      <div
        id="QuoteFormModal"
        className="hs-overlay hidden w-full h-full fixed top-0 start-0 z-[80] overflow-x-hidden overflow-y-auto pointer-events-none [--overlay-backdrop:static]"
        data-hs-overlay-keyboard="true"
      >
        <div className="hs-overlay-open:mt-0 hs-overlay-open:opacity-100 hs-overlay-open:duration-500 mt-10 opacity-0 transition-all w-full max-w-full fixed md:static bottom-0 md:hs-overlay-open:mt-10 md:mt-0 md:max-w-lg md:mx-auto">
          <div className="flex flex-col bg-white md:border rounded-t-xl md:rounded-b-xl pointer-events-auto md:shadow-sm">
            <div className="px-6 md:px-10">
              <ProgressBar
                currentStep={currentStep}
                totalSteps={totalSteps}
              />

              {renderStep()}
            </div>
          </div>
        </div>
      </div>
    </>
  );
}

export default QuoteForm;

Hi!
Thanks for noticing! We will fix this in the next update

@jahaganiev jahaganiev added the bug Something isn't working label Feb 28, 2024
@jahaganiev
Copy link
Member

jahaganiev commented Apr 3, 2024

Hey @gkcsabado - thanks for reporting the issue. We've just pushed the fixes in the v2.1.0 update. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants