Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from XML to xml2 #2

Open
burgerga opened this issue Jan 30, 2023 · 0 comments
Open

Switch from XML to xml2 #2

burgerga opened this issue Jan 30, 2023 · 0 comments
Labels
help wanted Extra attention is needed

Comments

@burgerga
Copy link
Contributor

Currently htmltab is removed from CRAN (#1) due to an error popping up in one of the unit tests:

Version: 0.8.2
Check: tests
Result: ERROR
     Running ‘spelling.R’
     Running ‘testthat.R’ [4s/18s]
    Running the tests in ‘tests/testthat.R’ failed.
    Complete output:
     > library(testthat)
     > test_check("htmltab")
     Loading required package: htmltab
     [ FAIL 1 | WARN 15 | SKIP 1 | PASS 112 ]
    
     ══ Skipped tests ═══════════════════════════════════════════════════════════════
     • On CRAN (1)
    
     ══ Failed tests ════════════════════════════════════════════════════════════════
     ── Error ('test_expand_spans.R:257'): http://stackoverflow.com/questions/24215584/html-complex-tables ──
     Error in `if (e$code == xmlParserErrors["XML_IO_LOAD_ERROR"]) stop(e)`: argument is of length zero
     Backtrace:
     ▆
     1. ├─XML::htmlParse(stack) at test_expand_spans.R:257:2
     2. └─XML (local) `<fn>`(...)

(full report at https://cran-archive.r-project.org/web/checks/2022/2022-11-11_check_results_htmltab.html)

This is a regression caused by some combination of R > 4.2.2 and XML, and is not due to htmltab, however, XML is in keep-alive mode so I don't expect changes in XML, so the suggestion by CRAN (de facto XML maintainer) was to move from XML to xml2.

This will be quite a lot of work...
Some tips to get started here: https://gist.github.com/nuest/3ed3b0057713eb4f4d75d11bb62f2d66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant