Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can no longer invert sort order when displayed as a tree #1479

Closed
cherio opened this issue May 15, 2024 · 9 comments
Closed

Can no longer invert sort order when displayed as a tree #1479

cherio opened this issue May 15, 2024 · 9 comments
Labels
Linux 🐧 Linux related issues support request This is not a code issue but merely a support request. Please use the mailing list or IRC instead.

Comments

@cherio
Copy link

cherio commented May 15, 2024

Version 3.3.0 (Arch Linux)

Test case:

  1. Select tree view presentation (F5)
  2. Make sure "Tree view is always sorted by PID" is not selected/unchecked in the settings
  3. Choose a sort column, e.g. TIME (either with F6 or mouse)
  4. Try to invert sort order with either pressing "I" or mouse click on the column header.

Expected behavior:

  • The tree should get reverse-sorted
  • The little up/down arrow in the header should reverse its direction

Observed behavior:

  • The sort stays the same.
  • The sort direction arrow only changes direction when using keyboard "I", but stays unchanged when using mouse.
@fasterit
Copy link
Member

Cannot confirm, please try clicking the PID header ... it is most easy to see the inversion there.
TIME+ works here, too.

@BenBE
Copy link
Member

BenBE commented May 15, 2024

The tree is sorted in a way, that the sort order is applied to the children (of the same level) of each parent …

Nicely visible with the RES (memory usage) column …

@BenBE BenBE added support request This is not a code issue but merely a support request. Please use the mailing list or IRC instead. Linux 🐧 Linux related issues labels May 15, 2024
@cherio
Copy link
Author

cherio commented May 15, 2024

I've done some additional testing

  • tried sorting by various columns including PID
  • removed/re-installed htop from the standard Arch repo
  • purged .config/htop
  • updated the system
  • I tried various terminals, including the basic tty

The sorting issue persisted after everything. I have the total of 3 Archlinux boxes and all of them have the issue.

At the same time I tested 3.3.0 in Ubuntu and Debian have no such issues.

Unless you have more insight, I guess this could be a dependency or Arch build issue

@cherio
Copy link
Author

cherio commented May 15, 2024

I ran 2 more tests, compiling it from scratch

  1. I pulled the latest source from here, compiled it and ran. The issue was not present.
  2. I pulled branch 3.3.0 and compiled it. The issue was present.

This means the issue is not Arch specific.

@fasterit
Copy link
Member

That's why good distros backport patches :-)
https://sources.debian.org/patches/htop/3.3.0-4/

@eworm-de
Copy link
Contributor

Ha, looks like we need an upstream release! 😜

Probably fixed by 91990b1...

@BenBE
Copy link
Member

BenBE commented May 15, 2024

Ha, looks like we need an upstream release! 😜

Once the CPU topology stuff for libsensors are satisfactorily fixed …

@eworm-de
Copy link
Contributor

The fix should be in htop 3.3.0-3. I guess we can close this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Linux 🐧 Linux related issues support request This is not a code issue but merely a support request. Please use the mailing list or IRC instead.
Projects
None yet
Development

No branches or pull requests

4 participants