-
-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AIX port #584
Comments
@mmetts which branch is that? I couldn't see one with anything AIX related in the name ... FWIW, I'd be happy to help some other developer working on AIX with keeping the platform up-to-date but I don't have access to an AIX machine myself. |
Hi! this is the one I'm thinking about hishamhm/htop#832 |
Let's see if any of those folks are still around ... ping @NattyNarwhal @kadler @bmarwell ... are you interested in collaborating on an AIX version of htop? |
Hi Nathan, |
The largest chunk of work with this patchset will consist of mostly three tasks:
But before those tasks can be worked on I think it's important, as @natoscott said, to ger permission from the previous authors of that patchset, or even better: get them to help with that porting work. Given that we have quite a list of tasks ahead even without this AIX port, we're dependent on any helping hand we can get to bring this port forward. We'll try to assist where possible, but the most part should be worked on with people knowing that platform and having a proper development environment for it. |
yes, I'm around. i don't use AIX as much as I used to (since I got a box fast enough I didn't need to cross-compile anymore), but I'd be willing to put what I had upstreamed. |
Pinging @LionNatsu: Is it okay to use your commit hishamhm/htop@67e3689 in the porting work going forward? |
@NattyNarwhal Could you try to work on the first two points on the list I posted? We'll likely get to the third one soon enough, but having especially the first one out of the picture should simplify going forward quite a bit. One note regarding OS checks: please create a define |
I got a working version, but I don't remember which branches I used and I am sadly not a C coder. But I can compile things on AIX and give feedback. |
Discussing this issue in our developer meeting we decided that AIX support is currently no priority as we are seriously lacking demand for it and also are much to short on resources to handle the work necessary to maintain that platform. Thus said, while we may reconsider the inclusion once a workable patch for integration of AIX support is presented, we'll as of now not go forward on its inclusion. Once workable patches for such support are made we'll be glad to help with bringing them further. Considering our current list of open tasks we'll not be putting any effort into adding support for AIX. |
I am a C programmer. I am interested in creating a usable patch. Was hoping someone could point me to what's already been done since there was some previous work on this and I can see what needs to be added from there to make it work with the current version. Thanks. |
Hey, @lm8. Thank you very much for the offer! |
I'd use it at work. 🙋🏻♂️ |
@bmarwell Where shall we send the invoices? Or did you ask for pity? 😁 |
If you ever used AIX you knew there is only "topas". I guess that says it all. 😉 Being an OSS maintainer myself, I might drop a donation or two. |
If you'd need a team to support it instead of one person, then I'll just fork from the current version add what patches I need to make it work and keep it for personal use. It'll at least be helpful at my workplace. Sorry to have bothered you. I typically like to send my patches upstream if they'll accept them. |
While we usually welcome contributions to allow The second condition we have for including a platform is a minimum feature coverage that covers at a minimum all general (cross-platform) columns as well as similar columns from related platforms. Similar rules apply for available meters. Furthermore there should be some serious user base for the platform that's not just a few enthusiasts or loosely linked to the original creators. With AIX the main impression on can get that having people "include support" for this platform is mainly an ad campaign to boost its relevancy without adding much value to Also you should be aware that we take code quality serious and in particular the initial PR for that platform will likely involve quite a bit of review discussion and refactoring to meet our quality standards. The rules laid out in our style guide document just the bare minimum of what we expect and while they aren't absolute they still give a reasonable guide to work with. It also helps to be around in our developer channel on IRC to allow for questions and strategic planning if necessary. So, going forward I see the following things to do, if adding AIX platform support to
If you don't want to put this effort into it I'm afraid AIX is not a sustainable platform for |
That works just fine, have used an old fork for a few years now.
AIX and enthussiasts? I am not sure AIX is used a lot on private computers.
Bummer. Will continue using @lm8's fork. |
Is someone going to take up the branch in the old repo and finish getting htop working on AIX? Please advise. Thanks.
The text was updated successfully, but these errors were encountered: