Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove exclamation point with > 100 days uptime #614

Closed
jorisw opened this issue Apr 26, 2021 · 1 comment
Closed

Remove exclamation point with > 100 days uptime #614

jorisw opened this issue Apr 26, 2021 · 1 comment

Comments

@jorisw
Copy link

jorisw commented Apr 26, 2021

The exclamation point in the following line:

Uptime: 148 days(!), 21:52:29

... serves no clear purpose, and causes people to spend time searching for what it means.

Better to remove it, as > 100 days uptime is no meaningful vector to warn the user about, nor is it clear that it stands for > 100 days uptime.

See discussion at Stack Overflow.

Relevant code:

xSnprintf(daysbuf, sizeof(daysbuf), "%d days(!), ", days);

@BenBE BenBE added the needs-discussion 🤔 Changes need to be discussed and require consent label Apr 26, 2021
@fasterit fasterit removed the needs-discussion 🤔 Changes need to be discussed and require consent label Apr 26, 2021
@fasterit
Copy link
Member

Hi @jorisw,
we discussed your proposal in the core team and decided to keep the functionality.
The rationale is:

  • Not having rebooted a system 100+ days is noteworthy
  • Most people get the meaning of the (!) intuitively (we've had zero support requests for this)
  • It is a historic feature
  • We are generally pro-easter-eggs. These are a cultural feat for software that is made artisanal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants