You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is mostly a usability issue, not a technical one.
Currently, I have to override RUST_LOG in order to see that the daemon detected my switch-keys and changed client. Compared to the other log messages, I believe this log message is equally important, and should be changed to a tracing::info.
Another change that would be nice, maybe the logs could use something more identifying than the client index? The hostname of the client would be optimal, but probably requires protocol changes. An alternative would be the clients IP address. It seems relatively trivial to store the address along with its mpsc sender. Not sure if this introduces any security risks though.
This is mostly a usability issue, not a technical one.
Currently, I have to override
RUST_LOG
in order to see that the daemon detected my switch-keys and changed client. Compared to the other log messages, I believe this log message is equally important, and should be changed to atracing::info
.Another change that would be nice, maybe the logs could use something more identifying than the client index? The hostname of the client would be optimal, but probably requires protocol changes. An alternative would be the clients IP address. It seems relatively trivial to store the address along with its mpsc sender. Not sure if this introduces any security risks though.
The relevant line:
rkvm/rkvm-server/src/server.rs
Line 210 in 825ed09
Current log output:
I don't mind creating a PR if I'm given green lights!
The text was updated successfully, but these errors were encountered: