"GET" a bytes array instead of a string

[Dinduks]

Hi,

I've search everywhere but couldn't find a hint about how to get a binary file, i.e. an array of bytes instead of a body.

When doing it the normal way, the body's size isn't correct; it's approximatively twice as big as it should. Probably due to the encoding.

My code at the moment:

(let [content-in-bytes (. (:body @p) getBytes)]
  (. file-channel write
    (ByteBuffer/wrap content-in-bytes)
    (:start-offset promises-hash)))

Can someone suggest how I should deal with this?

Thanks!

[shenfeng]

Hi, with this commit a15fde2,

It's possible to say something like this (modeled after clj-http):

(let [body (:body @(http/get "http://site.com/favicon.ico" {:as :byte-array}))]
  ;; body is a byte array
  ;; other options: :auto, :text :stream
  )

[http-kit "2.1.0-SNAPSHOT"]

Can you help review the API: is the :as option looks good, the :text :auto :byte-array :stream make sense?

@ptaoussanis , any ideas?

[Dinduks]

Damn, you're fast! :)
As a user, the API looks fine to me.

Thank you.