Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ring websocket API support #541

Closed
weavejester opened this issue Sep 30, 2023 · 4 comments
Closed

Ring websocket API support #541

weavejester opened this issue Sep 30, 2023 · 4 comments

Comments

@weavejester
Copy link
Contributor

I've been working on a Ring websocket API that's currently in experimental alpha. Would you be interested in a PR to support this in http-kit, to be merged when the Ring websocket API is stable? It would obviously be supported in conjunction with http-kit's native implementation.

The reason I'm asking this while the Ring API is still experimental is that I'd like to try implementing the API for different third-party adapters, so I can get feedback and forewarning of any design issues. I've submitted a similar issue to the ring-jetty9-adapter project.

@ptaoussanis
Copy link
Member

@weavejester Hi James, would be very interested in a PR - that'd be great!

Thanks so much for thinking of http-kit, cheers :-)

@weavejester
Copy link
Contributor Author

No problem! My current plan is to add a pongHandler to AsyncChannel, and create a PingMessage and PongMessage class for use with AsyncChannel.send, in order to allow the ping/pong support that the Ring websocket spec requires. Does this seem a reasonable approach?

@ptaoussanis
Copy link
Member

I'm not familiar with the Ring websocket spec, but your plan sounds very reasonable from http-kit's end 👍

@ptaoussanis
Copy link
Member

#546 has been merged 👍 Thanks James!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants