Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception after 1.15.1 #1064

Open
ducklord opened this issue Sep 20, 2016 · 3 comments
Open

Exception after 1.15.1 #1064

ducklord opened this issue Sep 20, 2016 · 3 comments

Comments

@ducklord
Copy link

Hey

We are getting this exception The header content contains invalid characters after the update of 1.15.1. The reason is that union's response-stream does not implement the interface you describe in the 1.15.1 patch.

TypeError: The header content contains invalid characters
    at ServerResponse.OutgoingMessage.setHeader (_http_outgoing.js:351:13)
    at ResponseStream.writeHead (node_modules/union/lib/response-stream.js:75:21)
    at Array.writeStatusCode (node_modules/http-proxy/lib/http-proxy/passes/web-outgoing.js:113:11)
    at ClientRequest.<anonymous> (node_modules/http-proxy/lib/http-proxy/passes/web-incoming.js:157:20)

Not sure if you are willing to fix this, since this is basically unions fault. But the error is first exposed in your 1.15.1.

Best regards
Anders

@reykjavikingur
Copy link

+1
I'm seeing this in Chrome 52 running it as part of Express middleware. It happens in 1.15.1 and 1.15.2, but it is fine in 1.13.3.

@jcrugzz
Copy link
Contributor

jcrugzz commented Oct 22, 2016

@ducklord the fix should be in union. @reykjavikingur could you post some code, a stacktrace and the version of express this is associated with?

@jcrugzz
Copy link
Contributor

jcrugzz commented Oct 22, 2016

This should be fixed with latest union which would be installed with latest http-server. @reykjavikingur would love to see a test for your failure case added to this project. It doesn't seem clear to me why this would be happening with standard express

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants