New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API not consistent between .createProxy and .createProxyServer #606

Closed

indexzero opened this issue Mar 25, 2014 · 1 comment

Contributor

indexzero commented Mar 25, 2014

@yawnt pretty simple fix here. We lost backwards compatibility hard.

https://github.com/nodejitsu/node-http-proxy/blob/master/lib/http-proxy.js#L11-L16

Contributor

yawnt commented Mar 25, 2014

they are not the same thing, a ProxyServer is expected to be used as a server, while Proxy just provides the two function for proxying..

that said, if you think it's better to change it, i can do that ... what do you need exactly? just createProxy to behave like createProxyServer?

jcrugzz closed this as completed in

c6b7a79

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment