Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include port when using changeOrigin #750

Closed
wants to merge 1 commit into from
Closed

Include port when using changeOrigin #750

wants to merge 1 commit into from

Conversation

magicalhobo
Copy link

According to the HTTP spec, the port needs to be included in the host header if it's not the default port. It can be included even if it is the default port, so the easiest thing to do is always include it.

According to the HTTP spec, the port needs to be included in the host header if it's not the default port. It can be included even if it is the default port, so the easiest thing to do is always include it.
@jcrugzz
Copy link
Contributor

jcrugzz commented Dec 8, 2014

@magicalhobo thanks for the contribution! Unfortunately we cannot make this assumption because the host property itself can include the port. (see how the url module behaves.) There will need to be something that better fits the type of inputs we get from a user.

@jcrugzz jcrugzz closed this in 501e8c2 Dec 8, 2014
@jcrugzz
Copy link
Contributor

jcrugzz commented Dec 8, 2014

@magicalhobo you can see the fix I made above, just want to make sure it works as expected in all cases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants