Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert from/into web_sys::Request/Response #317

Open
olanod opened this issue Dec 30, 2020 · 0 comments
Open

Convert from/into web_sys::Request/Response #317

olanod opened this issue Dec 30, 2020 · 0 comments

Comments

@olanod
Copy link

olanod commented Dec 30, 2020

It's nice that http-types compiles to WASM in the browser, even nicer would be to have a way to convert back and forth between the Request/Response types in this crate and the "native" JS Request/Response to avoid wrapping with a new type. The feature can be gated with a flag(e.g. web).
This is probably better and more general purpose than what I proposed in http-rs/http-client#60 and can eventually simplify the code over there. I also think conversion could be made more efficient if the JS Request/Response body that is a ReadableStream(implements the asyncIterator protocol) is converted to a Stream/AsyncReader, modern Chrome even allows transferring those streams with the postMessage API so for my use case of intercepting requests from a ServiceWorker to be handled in a Worker(Using Rust and http-types) could be made much more efficient in the future.

@olanod olanod changed the title Convert from/into web_sys::Request Convert from/into web_sys::Request/Response Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant