Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shearl: s/GOAWAY/GO_AWAY, s/REFUSED_STREAM/RETRY_STREAM, s/RST_STREAM/TERMINATE_STREAM #576

Closed
wants to merge 3 commits into from

Conversation

shearl
Copy link
Contributor

@shearl shearl commented Aug 1, 2014

renamed GOAWAY to GO_AWAY to be consistent with the naming for other two-word frame types ie RST_STREAM, PUSH_PROMISE and WINDOW_UPDATE

s/REFUSED_STREAM/RETRY_STREAM The definition of REFUSED_STREAM is somewhat contradictory with the definition of the word refused. The word refused is defined as: indicate or show that one is not willing to do something (https://www.google.at/). The definition of REFUSED_STREAM in Section 7 references section 8.1.4 which says that a REFUSED_STREAM is safe to retry. In other words the server is actually willing to process the stream, but currently unable (e.g. because the client overran settings and so the client needs to retry the stream with the new settings.)

s/RST_STREAM/TERMINATE_STREAM The definition of RST_STREAM doesn't match the meaning of the word reset. The word reset generally means: "cause (a binary device) to enter the state representing the numeral 0." [http://www.oxforddictionaries.com/definition/english/reset] In other words, the word reset implies that the stream should be reset back to its original state (i.e. IDLE), but RST_STREAM immediately takes a stream to its terminal state (i.e. CLOSED).

…two-word frame types ie RST_STREAM, PUSH_PROMISE and WINDOW_UPDATE
…ewhat contradictory with the definition of the word refused. The word refused is defined as: indicate or show that one is *not willing* to do something (https://www.google.at/).  The definition of REFUSED_STREAM in Section 7 references section 8.1.4 which says that a REFUSED_STREAM is safe to retry.  In other words the server is actually *willing* to process the stream, but *currently unable* (e.g. because the client overran settings and so the client needs to retry the stream with the new settings.)
@shearl shearl changed the title shearl: s/GOAWAY/GO_AWAY shearl: s/GOAWAY/GO_AWAY & s/REFUSED_STREAM/RETRY_STREAM Aug 1, 2014
@shearl shearl changed the title shearl: s/GOAWAY/GO_AWAY & s/REFUSED_STREAM/RETRY_STREAM shearl: s/GOAWAY/GO_AWAY, s/REFUSED_STREAM/RETRY_STREAM, s/RST_STREAM/TERMINATE_STREAM Aug 1, 2014
@davegarrett
Copy link
Contributor

If you're renaming things for consistency, might I suggest having all 3 stream error names in the same format of "STREAM_type" (or "type_STREAM").

Also, you could use "drop" instead of "retry" or "refused" if you're looking for more literal meanings.
(& add a note about the ability to retry where needed)

The suggestion would be a matching set of:
STREAM_CLOSED
STREAM_DROPPED (formerly REFUSED_STREAM)
STREAM_CANCELED (formerly CANCEL)

If you want to be pedantic, you could also rearrange the list to have all "ERROR" together sequentially then all "STREAM" sequentially after that, though changing values this late in the game probably isn't worth it.

@mnot
Copy link
Member

mnot commented Nov 3, 2014

Closing, as this has become out of sync with he spec. If you're still interested, I think it'd be better to talk about it on-list first, as we're in a stage where even small changes to the spec are getting a lot of scrutiny.

@mnot mnot closed this Nov 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants