Update PUSH_PROMISE text in Section 5.1 and improve Figure 2. ASCII art diagram #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 26, 2014 20:40
whether a frame is being sent, received or both with each transition. This makes the diagram 4 characters wider.
and made the previous two git commits.
|
I'm going to send this to the list, but I think that this is OK. |
|
I updated the pull request by replacing either with recv/send as suggested on the list: #659. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Martin,
I believe the current text is wrong/confusing for PUSH_PROMISE in the "Section 5.1 Stream states" section, as associated streams aren't marked in any way, and are already in use, rather than "reserve for later use". This caused me confusion when I was implementing as to which stream was "associated" (the new promised stream or the existing stream). I hope my pull request clarifies this text.
I've also improved the ASCII art diagram for Figure 2, albeit at the cost of an extra 4 characters width, which shows whether a frame is being sent, received or both for each transition.
Many thanks,
Jonathan.