Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scala-2.13.0 #2025

Closed
rossabaker opened this issue Aug 20, 2018 · 13 comments
Closed

scala-2.13.0 #2025

rossabaker opened this issue Aug 20, 2018 · 13 comments

Comments

@rossabaker
Copy link
Member

  1. Publish our internal dependencies.
  2. Identify which of our external dependencies are published.
  3. Once they all are, publish.

Recommend we begin this exercise with 2.13.0-M5.

Our monorepo is going to mean we're at the tail end of this, which is why we haven't even tried yet.

@rossabaker
Copy link
Member Author

There is no scalacheck-2.13.0-M5 yet, and cats-1.3.0 looks like it will ship on 2.13.0-M4. We might want to target M4 instead, though it's sad to start out a step behind. The value is that we can see what breaks.

@SethTisue
Copy link
Contributor

many more of your dependencies have now published for 2.13.0-M5

maybe it's time to take a fresh whack at this, see what's missing, and see what other maintainers we should go (politely) pester...?

@aeons
Copy link
Member

aeons commented Feb 5, 2019

Currently core has two dependencies that have no 2.13.0-M5 release:

  • log4s, which builds on 2.13, but just needs a release (issue here)
  • Our shapeless-less fork of parboiled http4s/parboiled2, which only needs a few fixes and a release

With those published locally, I'm running into some issues with scalacOptions that are no longer supported, but I can't figure out where in the build they are set. Will continue investigating.

@rossabaker
Copy link
Member Author

scalacOptions are set by sbt-tpolecat. It's possible that needs a bump or a fix. A nice thing about sbt-tpolecat is it should give us reasonable flags out of the box for crossbuilds.

@aeons
Copy link
Member

aeons commented Feb 5, 2019

Where is sbt-tpolecat added to the build? I couldn't find it in plugins.sbt

@ChristopherDavenport
Copy link
Member

It comes in through sbt-rig

@rossabaker
Copy link
Member Author

It should be overridable if there's a new version.

Worst case, scalacOptions can be tweaked post-plugin.

@SethTisue
Copy link
Contributor

I opened typelevel/sbt-tpolecat#5

@aeons
Copy link
Member

aeons commented Feb 5, 2019

I opened http4s/parboiled2#5

The build failure looks like some issue with string comparisons. If anyone wants to take a look at it, feel free.

@SethTisue
Copy link
Contributor

fixed in sbt-tpolecat 0.1.5, according to
typelevel/sbt-tpolecat#5 (comment)

@aeons
Copy link
Member

aeons commented Feb 6, 2019

I opened Verizon/sbt-rig#25 to get it into our build as well.

@rossabaker
Copy link
Member Author

I approved that, but the Verizon infrastructure for rig is gone, and that project hasn't been ported to the Nelson org yet. Can we just override the plugin version here to keep things moving?

@aeons
Copy link
Member

aeons commented Feb 6, 2019

Yep, I have a branch I'm working on. Will get it pushed soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants