Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quick start page is outdated #3260

Closed
anilkumarmyla opened this issue Mar 18, 2020 · 4 comments
Closed

Quick start page is outdated #3260

anilkumarmyla opened this issue Mar 18, 2020 · 4 comments
Labels
docs Relates to our website or tutorials

Comments

@anilkumarmyla
Copy link
Contributor

In https://http4s.org/v0.21/ this part about HelloWorldServer & HelloWorldService and the subsequent lines don't match the current code in http4s.g8 (this was part of 0.18 series)

$ find src/main -name '*.scala'
./src/main/scala/com/example/http4squickstart/HelloWorldServer.scala
./src/main/scala/com/example/http4squickstart/HelloWorldService.scala
@rossabaker rossabaker added the docs Relates to our website or tutorials label Mar 19, 2020
@rossabaker
Copy link
Member

Agreed. Any volunteers to clean this up? It would be in docs/src/main/tut/index.md.

@Guisanpea
Copy link
Contributor

Taking a look to it

@Guisanpea Guisanpea mentioned this issue Jun 28, 2020
Merged
@Guisanpea
Copy link
Contributor

Shouldn't this be marked as solved?

@rossabaker
Copy link
Member

Yes! Sometimes we miss these when the PR doesn't have one of the magic GitHub ticket-closing words.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs Relates to our website or tutorials
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rossabaker @anilkumarmyla @Guisanpea