Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running lint results in errors #7370

Open
SallyPerez opened this issue Jan 26, 2024 · 1 comment
Open

Running lint results in errors #7370

SallyPerez opened this issue Jan 26, 2024 · 1 comment

Comments

@SallyPerez
Copy link
Contributor

When running sbt lint, the following errors result in a Compilation Failed. These errors do not show up in the CI builds. The Contributing instructions do not mention lint, only quicklint, to be run before submitting a PR so that should be updated too.

Errors:

[error] .../http4s/scalafix-internal/input/src/main/scala/fix/LiteralsSyntaxWithExistingImplicitsImportTests.scala:8:29: Unused import
[error] import org.http4s.implicits._
[error]                             ^
[error].../http4s/scalafix-internal/input/src/main/scala/fix/LiteralsSyntaxWithExistingSyntaxImportTests.scala:8:30: Unused import
[error] import org.http4s.syntax.all._
[error]                              ^
[error] No warnings can be incurred under -Xfatal-warnings.
[error] three errors found
...
[error] .../http4s/scalafix-internal/output/src/main/scala/fix/LiteralsSyntaxWithExistingImplicitsImportTests.scala:3:19: Unused import
[error] import org.http4s.Uri
[error]                   ^
[error] .../http4s/scalafix-internal/output/src/main/scala/fix/LiteralsSyntaxWithExistingSyntaxImportTests.scala:3:19: Unused import
[error] import org.http4s.Uri
[error]                   ^
...
[error] No warnings can be incurred under -Xfatal-warnings.
[error] three errors found

Possible solution steps:

  • Find out what is exempting these errors in the CI that is being enforced in lint
  • Adjust the lint
  • Update the Contributing documentation to include running lint
@rossabaker
Copy link
Member

For the bazillion labels that we have, I'm not sure what to put on this one. It's a real issue, but we don't have anything that covers DX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants