Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swagger is generating invalid docs #47

Open
bryce-anderson opened this issue Dec 9, 2014 · 3 comments
Open

Swagger is generating invalid docs #47

bryce-anderson opened this issue Dec 9, 2014 · 3 comments
Assignees
Labels

Comments

@bryce-anderson
Copy link
Member

As noted in #46, the swagger validator has alerted us that the docs generated by the http4s demo are invalid.

@bryce-anderson bryce-anderson self-assigned this Dec 9, 2014
@bryce-anderson bryce-anderson added this to the 0.3.0 milestone Dec 9, 2014
@bryce-anderson bryce-anderson removed this from the 0.3.0 milestone Jan 27, 2015
@jcranky
Copy link
Contributor

jcranky commented Dec 22, 2016

Is this still a thing?

@bryce-anderson
Copy link
Member Author

Yes, it's still not perfect.

@bryce-anderson
Copy link
Member Author

I looked into this a bit, and the example with bad docs is not entirely rho's fault: the return type of a route is a JValue, which has no special meaning to rho so it fails to build a proper model for it. The other example is twirl Html, which is the same issue.

I still think rho could be smarter about what it's adding as a ref etc to avoid situations like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants