Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate keys preservation of JSON data #1163

Merged
merged 5 commits into from
Sep 21, 2021
Merged

Fix duplicate keys preservation of JSON data #1163

merged 5 commits into from
Sep 21, 2021

Conversation

BoboTiG
Copy link
Contributor

@BoboTiG BoboTiG commented Sep 21, 2021

Supersedes #1136 (I messed up with remote repositories).

Fixes #1133.

@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2021

Codecov Report

Merging #1163 (21bb027) into master (4d7d6b6) will decrease coverage by 0.01%.
The diff coverage is 99.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1163      +/-   ##
==========================================
- Coverage   97.28%   97.26%   -0.02%     
==========================================
  Files          67       70       +3     
  Lines        4235     4316      +81     
==========================================
+ Hits         4120     4198      +78     
- Misses        115      118       +3     
Impacted Files Coverage Δ
httpie/output/formatters/colors.py 92.66% <83.33%> (-0.92%) ⬇️
httpie/__init__.py 100.00% <100.00%> (ø)
httpie/cli/requestitems.py 91.17% <100.00%> (ø)
httpie/output/formatters/json.py 100.00% <100.00%> (ø)
httpie/output/lexers/http.py 100.00% <100.00%> (ø)
httpie/output/lexers/json.py 100.00% <100.00%> (ø)
httpie/output/utils.py 100.00% <100.00%> (ø)
httpie/utils.py 100.00% <100.00%> (ø)
tests/fixtures/__init__.py 100.00% <100.00%> (ø)
tests/test_cli.py 100.00% <100.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6c5cd3...21bb027. Read the comment docs.

httpie/utils.py Outdated Show resolved Hide resolved
tests/test_json.py Outdated Show resolved Hide resolved
httpie/utils.py Outdated Show resolved Hide resolved
httpie/utils.py Outdated Show resolved Hide resolved
@jkbrzt jkbrzt merged commit d7ed45b into httpie:master Sep 21, 2021
@BoboTiG BoboTiG deleted the mickael/dev-303-dont-silently-fix-invalid-json-with branch September 21, 2021 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't silently fix invalid JSON with duplicate keys
3 participants