Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the ability to silence warnings via double -q or --quiet #1175

Merged
merged 5 commits into from Oct 8, 2021

Conversation

dkreeft
Copy link
Contributor

@dkreeft dkreeft commented Oct 7, 2021

No description provided.

@dkreeft
Copy link
Contributor Author

dkreeft commented Oct 7, 2021

Closes #1100

Copy link
Member

@jkbrzt jkbrzt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Here are a few comments:

httpie/cli/argparser.py Outdated Show resolved Hide resolved
tests/test_output.py Outdated Show resolved Hide resolved
tests/test_output.py Outdated Show resolved Hide resolved
tests/test_output.py Outdated Show resolved Hide resolved
tests/test_output.py Outdated Show resolved Hide resolved
tests/test_output.py Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
httpie/cli/definition.py Outdated Show resolved Hide resolved
@jkbrzt jkbrzt changed the title change behavior of '--quiet' to silence errors and warnings when pass… Added the ability to silence warnings via double -q or --quiet Oct 7, 2021
Co-authored-by: Jakub Roztocil <jakub@roztocil.co>
@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2021

Codecov Report

Merging #1175 (361acbf) into master (4d7d6b6) will decrease coverage by 0.58%.
The diff coverage is 92.28%.

❗ Current head 361acbf differs from pull request most recent head c07d88f. Consider uploading reports for the commit c07d88f to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1175      +/-   ##
==========================================
- Coverage   97.28%   96.69%   -0.59%     
==========================================
  Files          67       70       +3     
  Lines        4235     4484     +249     
==========================================
+ Hits         4120     4336     +216     
- Misses        115      148      +33     
Impacted Files Coverage Δ
tests/test_auth.py 100.00% <ø> (ø)
tests/test_binary.py 100.00% <ø> (ø)
httpie/compat.py 16.66% <9.09%> (-83.34%) ⬇️
tests/conftest.py 75.75% <50.00%> (-11.20%) ⬇️
tests/test_ssl.py 91.01% <63.63%> (-3.93%) ⬇️
httpie/models.py 95.31% <72.72%> (-2.06%) ⬇️
httpie/output/formatters/colors.py 92.66% <83.33%> (-0.92%) ⬇️
httpie/__init__.py 100.00% <100.00%> (ø)
httpie/cli/argparser.py 95.56% <100.00%> (-0.80%) ⬇️
httpie/cli/argtypes.py 95.27% <100.00%> (+0.36%) ⬆️
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50f57f8...c07d88f. Read the comment docs.

@dkreeft
Copy link
Contributor Author

dkreeft commented Oct 8, 2021

Thanks @jakubroztocil, processed all of your suggestions. One comment is still open, do you have any suggestions?

everything is resolved.

docs/README.md Outdated Show resolved Hide resolved
tests/test_output.py Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@BoboTiG
Copy link
Contributor

BoboTiG commented Oct 8, 2021

Thanks @dkreeft, that's great work :) 🥧

@jkbrzt jkbrzt self-requested a review October 8, 2021 12:16
@jkbrzt jkbrzt merged commit 6befaf9 into httpie:master Oct 8, 2021
@jkbrzt
Copy link
Member

jkbrzt commented Oct 8, 2021

@dkreeft thanks! 🚀 🥧

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants