[WIP] Upgrade to prompt_toolkit 2.0 #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanslenders
force-pushed
the
prompt-toolkit-2.0
branch
from
e773b7d
to
34de861
Compare
|
See also: prompt-toolkit/python-prompt-toolkit#568 |
|
@jonathanslenders thanks so much for the effort! We only need synchronous completion since the completion in http-prompt is simple and fast. |
jonathanslenders
force-pushed
the
prompt-toolkit-2.0
branch
from
657c523
to
d3d84de
Compare
|
Could you please update your pull request to address the failing check? I manually patched the cli.py and utils.py files (not requirements.txt - updated metadata.json instead) and your patch appears to work fine with prompt_toolkit 2.0. Thanks, |
|
Is there an update on this pull request? |
|
Hopefully this can be fixed/merged soon. Thanks! |
BoboTiG
reviewed
Aug 5, 2021
|
Thanks a lot @jonathanslenders and sorry for the delay :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the changes required for upgrading to prompt_toolkit 2.0 once it's released.
Do you need asynchronous autocompletion or not? By default, completion is synchronous, but we can make it async if completion takes too much time.