Update to prompt_toolkit 2.0.x - take over jonathanslenders's works #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boarnasia
changed the title
|
Oh, it has problems on python27. |
iPython on py27 uses prompt-toolkit<2.0.0, and on py36 uses prompt-toolkit>2.0.0, so I put changes that environment on python2 uses prompt-toolkit<2.0 and environment on python3 uses prompt-toolkit>2.0.
Since pytest-cov ver 2.6, it needs pytest v3.6 over, so pytest-cov version should be limited under 2.6.0.
|
Since pytest-cov v2.6, it needs pytest v3.6 over. Latest pytest ver is 4.3.1. I think it is better to update pytest minimum version to over 3.6. |
boarnasia
changed the title
|
How do you think about changing prompt-toolkit version according to iPython? iPython have 3 version combination patterns as wrote below:
I think most people suffer from incompatible prompt-toolkit version between http-prompt and iPython, therefore I think changing PT version according to iPython is good idea personally. |
tcorbettclark
pushed a commit
to Encapsia/encapsia-cli
that referenced
this pull request
Aug 19, 2019
|
Why not use try: except: blocks and support both. |
|
I merged #137, this is no more needed (thanks @boarnasia for the patch). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I patched jonathanslenders's works into the latest source.
I don't know why this update stop for a long time, and creating new pull request is good manner or not, but I think http-prompt works with prompt_tookit 2.0.x is things I need.
Almost changes is the same as jonathanslenders's. I added only information message for KeyboardInterrupt exception on http_prompt/cli.py:169.