httpie output has lots of additional characters on windows #36

obmarg · 2012-03-19T15:26:48Z

Running http GET httpie.org on windows results in a load of extra characters being printed out:

HTTP/1.1 ←[39;49;00m←[34m302←[39;49;00m←[33m Found←[39;49;00m
Date:←[39;49;00m←[33m Mon, 19 Mar 2012 15:13:17 GMT←[39;49;00m
Server:←[39;49;00m←[33m Apache←[39;49;00m
X-Awesome:←[39;49;00m←[33m Thanks for trying HTTPie :)←[39;49;00m
Location:←[39;49;00m←[33m https://github.com/jkbr/httpie←[39;49;00m
Cache-Control:←[39;49;00m←[33m max-age=1800←[39;49;00m
Expires:←[39;49;00m←[33m Mon, 19 Mar 2012 15:43:17 GMT←[39;49;00m
Content-Length:←[39;49;00m←[33m 214←[39;49;00m
Content-Type:←[39;49;00m←[33m text/html; charset=iso-8859-1←[39;49;00m

←[36m<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">←[39;49;00m
←[34;01m<html←[39;49;00m←[34;01m>←[39;49;00m←[34;01m<head←[39;49;00m←[34;01m>←[39;49;00m
←[34;01m<title←[39;49;00m←[34;01m>←[39;49;00m302 Found←[39;49;00m←[34;01m</title>←[39;49;00m
←[34;01m</head>←[39;49;00m←[34;01m<body←[39;49;00m←[34;01m>←[39;49;00m
←[34;01m<h1←[39;49;00m←[34;01m>←[39;49;00mFound←[39;49;00m←[34;01m</h1>←[39;49;00m
←[34;01m<p←[39;49;00m←[34;01m>←[39;49;00mThe document has moved ←[39;49;00m←[34;01m<a←[39;49;00m ←[39;49;00m←[36mhref=←[39;49;00m←[33m"https://github.com/jkbr/httpie"←[39;49;00m←[34;01m>←[39;49;00mhere←[39;49;00m←[34;01m</a>←[39;49;00m.←[39;49;00m←[34;01m</p>←[39;49;00m

I'm guessing that these are escape codes that provide the colored output on other operating systems. Running http -u GET httpie.org results in correct (though monochrome) output.

It'd be nice to get cross platform colored output like provided by clint.

The text was updated successfully, but these errors were encountered:

lllama · 2012-05-08T19:32:09Z

It does look like the colorama module could be a fairly simple way to address this:
http://pypi.python.org/pypi/colorama

dethstryke · 2012-07-03T17:15:37Z

Bummed to find this bug, colored output would be nice.

jkbrzt · 2012-07-17T02:12:52Z

This should be fixed now. Thanks for the tip for colorama, it works very well. I've tested it on Python 2.7 under Windows 7 with PowerShell and cmd.exe.

It would be great if you could test it and provide feedback (I don't use Windows very often):

pip install -U https://github.com/jkbr/httpie/tarball/master

There is one remaining Windows-related issue (unicode in terminal #71).

obmarg · 2012-07-17T11:19:22Z

I've just tested with powershell, zsh & cmd.exe using Python 2.7 - seems to work perfectly. Thanks for the fix.

jkbrzt · 2012-07-17T14:17:39Z

Glad to hear that. Thanks for the feedback.

GuiSim · 2012-07-18T18:47:55Z

I get the following warnings when running httpie under PyPy 1.6 :

path\to\colorama\win32.py:17: RuntimeWarning: C function without declared arguments called
  STDOUT: windll.kernel32.GetStdHandle(STDOUT),
path\to\colorama\win32.py:18: RuntimeWarning: C function without declared arguments called
  STDERR: windll.kernel32.GetStdHandle(STDERR),
path\to\colorama\win32.py:64: RuntimeWarning: C function without declared arguments called
  handle, byref(csbi))
path\to\colorama\win32.py:70: RuntimeWarning: C function without declared arguments called
  return windll.kernel32.SetConsoleTextAttribute(handle, attrs)

I think that this is caused by PyPy (see http://mail.python.org/pipermail/pypy-commit/2011-April/049781.html)
but I suspect that the code could be changed to avoid this warning.

EDIT: Nevermind, these warnings are coming from Colorama.

http://code.google.com/p/colorama/issues/detail?id=26

dethstryke · 2012-07-18T19:18:48Z

I'm still getting this using ActivePython 3.2.2.3 I ran the update command you listed and am still getting the same output as before. Am I missing anything?

jkbrzt · 2012-07-19T09:44:38Z

@dethstryke What is the output of http --version? If it says something else than 0.2.6dev, then please try to uninstall the old version first and then install the dev one again:

pip uninstall httpie
pip install -U https://github.com/jkbr/httpie/tarball/master

kaplas · 2012-07-19T11:01:54Z

I'm sorry that I didn't notice this issue thread when making the pull request. Also when I named my fork, I didn't know that you have already included colorama in the project. However, the dev branch did not work for me. (http --version gives 0.2.6dev for me) As I mention in my pull request, I had to change the stdout writing to a single print statement to get it working.

As a proof, here's a screenshot showing installation from the dev branch (on the left) and then from my fork (on the right):
http://grab.by/eRsq

I also had to install 'requests' separately, because the one provided by pip didn't work on my system. But by installing requests directly from their git repo worked flawesly.

I'm totally newbie with python, pip and colorama, and quite newbie also with github, so I'm sorry if this is just some Stupid User Error. But I still think that there is something wrong with outputting to the cmd.exe window, and my pull request seems to fix it.

mieky · 2012-07-19T11:34:22Z

At a quick glance it would seem that a simple 'print output' (without any explicit encoding being done) works nicely on both Windows and OS X. I just want to understand the details involved - what would break if we were to remove the check for stdout.buffer and/or the encoding parts?

jkbrzt · 2012-07-19T12:09:05Z

@mieky Encoding the output ensures that unicode characters (like ě, not colors) are displayed correctly on the terminal. The way it's done now seems to work well under OS X and Linux on all the supported Pythons, but on Windows it's still displayed incorrectly (#71).

The color problem that some people are still seing on Windows is most likely caused by the fact that colorama is unable to process the output on some configurations (due to the way it's being written/encoded for OSX/Linux).

So, @cido's patch seems to solve the occasional color-related problems on Windows, but the output still needs to be encoded (somehow) to ensure that unicode works.

It's quite tricky to solve it universally. Any help appreciated.

mariodev · 2012-07-21T11:54:48Z

@jkbr Is there any changes I need to make to my win cmd.exe to prettify the output? Since I've installed 0.2.6-dev and still I get escape codes..

jkbrzt · 2012-07-21T13:12:33Z

Please try the current master:

pip install -U https://github.com/jkbr/httpie/tarball/master

mariodev · 2012-07-21T14:30:29Z

@jkbr Thank you, that worked.

jkbrzt · 2012-07-26T08:12:05Z

This seems to be fixed in 0.2.6. Please feel free to reopen this issue if the problem persists.

hickford · 2012-09-12T22:46:32Z

Thanks

pip install --upgrade httpie

mykwillis · 2015-08-22T00:48:29Z

I'm not sure if there was a regression of if there is some problem with my local terminal, but the most recent version is showing this behavior for me.

python --version
Python 3.4.3

http --version
0.9.2
←[0m

http httpie.org
←[38;5;33mHTTP←[39m←[38;5;245m/←[39m←[38;5;37m1.1←[39m←[38;5;245m ←[39m←[38;5;37m302←[39m←[38;5;245m ←[39m←[38;5;136mFound←[39m
←[38;5;245mConnection←[39m←[38;5;245m:←[39m←[38;5;245m ←[39m←[38;5;37mclose←[39m
←[38;5;245mContent-Length←[39m←[38;5;245m:←[39m←[38;5;245m ←[39m←[38;5;37m292←[39m
[...]

bryanbak · 2015-08-26T14:44:21Z

I just installed this on windows and am having the same issue as @mykwillis, but only in powershell. If I use httpie in the regular cmd prompt it looks fine.

Windows 7
python 2.7.10
httpie 0.9.2

mykwillis · 2015-08-26T19:04:29Z

I notice that if I

pip install colorama==0.3.2

as opposed to using the latest colorama (0.3.3), then I don't get the control characters in the output.

It's not in color, but at least it's not garbled.

So this is likely something to do with a change in colorama between 0.3.2 and 0.3.3

bryanbak · 2015-08-27T16:58:41Z

Just downgraded colorama to 0.3.2 based on @mykwillis suggestion and powershell output looks much better now. Thanks for the advice!

jkbrzt closed this as completed in 2dba176 Jul 17, 2012

jkbrzt mentioned this issue Jul 19, 2012

ANSI color strings are now processed by colorama on Windows #74

Closed

jkbrzt reopened this Jul 19, 2012

jkbrzt added a commit that referenced this issue Jul 21, 2012

Fixed colorama initialization (#36).

0a67361

jkbrzt closed this as completed Jul 26, 2012

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

httpie output has lots of additional characters on windows #36

httpie output has lots of additional characters on windows #36

obmarg commented Mar 19, 2012

lllama commented May 8, 2012

dethstryke commented Jul 3, 2012

jkbrzt commented Jul 17, 2012

obmarg commented Jul 17, 2012

jkbrzt commented Jul 17, 2012

GuiSim commented Jul 18, 2012

dethstryke commented Jul 18, 2012

jkbrzt commented Jul 19, 2012

kaplas commented Jul 19, 2012

mieky commented Jul 19, 2012

jkbrzt commented Jul 19, 2012

mariodev commented Jul 21, 2012

jkbrzt commented Jul 21, 2012

mariodev commented Jul 21, 2012

jkbrzt commented Jul 26, 2012

hickford commented Sep 12, 2012

mykwillis commented Aug 22, 2015

bryanbak commented Aug 26, 2015

mykwillis commented Aug 26, 2015

bryanbak commented Aug 27, 2015

httpie output has lots of additional characters on windows #36

httpie output has lots of additional characters on windows #36

Comments

obmarg commented Mar 19, 2012

lllama commented May 8, 2012

dethstryke commented Jul 3, 2012

jkbrzt commented Jul 17, 2012

obmarg commented Jul 17, 2012

jkbrzt commented Jul 17, 2012

GuiSim commented Jul 18, 2012

dethstryke commented Jul 18, 2012

jkbrzt commented Jul 19, 2012

kaplas commented Jul 19, 2012

mieky commented Jul 19, 2012

jkbrzt commented Jul 19, 2012

mariodev commented Jul 21, 2012

jkbrzt commented Jul 21, 2012

mariodev commented Jul 21, 2012

jkbrzt commented Jul 26, 2012

hickford commented Sep 12, 2012

mykwillis commented Aug 22, 2015

bryanbak commented Aug 26, 2015

mykwillis commented Aug 26, 2015

bryanbak commented Aug 27, 2015