Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP "via" for HTTP Proxy not working (0.5.0) #43

Closed
robertjpayne opened this issue Oct 4, 2013 · 4 comments · Fixed by #62
Closed

HTTP "via" for HTTP Proxy not working (0.5.0) #43

robertjpayne opened this issue Oct 4, 2013 · 4 comments · Fixed by #62

Comments

@robertjpayne
Copy link

I'm using Ruby 2.0.0 and HTTP 0.5.0 and using this tiny little example:

require 'http'
response = HTTP.via('192.168.1.1513', 8888).get("http://www.google.co.nz").response
puts response.body

The request goes through just fine but in reality I have no HTTP proxy sitting on that address or port. I've tried it with my real web debugger address/port as well but it still goes through.

Is there a special way to enable proxies? I should note I do have Celluloid/IO installed on my machine if it makes any difference.

@robertjpayne
Copy link
Author

Further to the point the specs are also broken because they do nothing to validate the request was actually sent through the proxy server and not delivered directly to the end server.

The spec's proxy server should likely tag the request with a header and/or piece of content in the body and have the spec validate that was added to the response to ensure it actually hits the proxy server, the proxy server.

@tarcieri
Copy link
Member

tarcieri commented Oct 4, 2013

I wouldn't be surprised if the proxy stuff is broken ;)

@ezkl interested in taking a look at this?

@LeeroyDownUnder
Copy link

+1 Just noticed. Requests were working great on an agent with .via, then I noticed the proxy was empty.

@tarcieri
Copy link
Member

tarcieri commented Jan 2, 2014

We should probably 1) remove this feature from future releases since it's broken or 2) actually fix it!

@ezkl any interest in actually fixing it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants