Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signatures: Host header #1921

Closed
yaronf opened this issue Feb 2, 2022 · 1 comment · Fixed by #1964
Closed

Signatures: Host header #1921

yaronf opened this issue Feb 2, 2022 · 1 comment · Fixed by #1964

Comments

@yaronf
Copy link
Contributor

yaronf commented Feb 2, 2022

There are quite a few occurrences of the Host header in the draft.

From an implementation point of view, Go "swallows" the Host header and it is not part of the standard Request structure. There's a good reason for the Go library to do it, and in fact the draft recommends to use @authority instead. Can we remove Host from examples, e.g. Sec. 2.1, so we don't train people to do the wrong thing?

@jricher
Copy link
Contributor

jricher commented Feb 11, 2022

There are only a couple instances of the "host" header in the current draft left, and one of them (section 2.1) is specifically about how to format headers. It could be removed from the other example signature input strings without affecting anything negatively. Same with the "date" header, which could be confused with the "created" parameter, see #1189

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

3 participants