Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary messages: Length fields aren't well-defined #1963

Closed
DavidSchinazi opened this issue Feb 9, 2022 · 0 comments · Fixed by #1995
Closed

Binary messages: Length fields aren't well-defined #1963

DavidSchinazi opened this issue Feb 9, 2022 · 0 comments · Fixed by #1995

Comments

@DavidSchinazi
Copy link
Contributor

This was buried inside #1944 which was closed so I'm opening a new issue.

The draft currently shows:

Known-Length Field Section {
  Length (i),
  Field Line (..) ...,
}

This Length field isn't well defined. Is it the length of the Known-Length Field Section in bytes or in lines? It would really help if this draft defined every single field it declares.

@martinthomson martinthomson linked a pull request Mar 9, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants