Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[signatures] Terminology introducing derived component values #2035

Closed
tyler-ham opened this issue Mar 18, 2022 · 2 comments
Closed

[signatures] Terminology introducing derived component values #2035

tyler-ham opened this issue Mar 18, 2022 · 2 comments

Comments

@tyler-ham
Copy link
Contributor

Most of the derived component sections (2.2.x) introduce an example of canonicalization like the following:

Would result in the following @scheme value:

"@scheme": http

In some cases, "component value" (5 instances) is used instead of "value" (8 instances).

However, the examples that immediately follow these introductions are complete signature base lines, not just component values.

I want to suggest normalizing these all to "component value" and expanding the examples to identify the component value and signature base line separately. For example:

For example, the following request message requested over plain HTTP:

POST /path?param=value HTTP/1.1
Host: www.example.com

Would result in the following @scheme component value:

http

And the following signature base line:

"@scheme": http

I will send a pull request to show what I'm thinking here.

@jricher
Copy link
Contributor

jricher commented Mar 22, 2022

I personally find this a bit verbose, but it's better to over-explain than under-explain with the examples, so we'll take these in.

@jricher jricher closed this as completed Mar 22, 2022
@tyler-ham
Copy link
Contributor Author

I personally find this a bit verbose, but it's better to over-explain than under-explain with the examples

I share the same sentiments on both points. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants