Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy-Status: add Proxy Internal Response. #807

Closed
PiotrSikora opened this issue May 3, 2019 · 3 comments
Closed

Proxy-Status: add Proxy Internal Response. #807

PiotrSikora opened this issue May 3, 2019 · 3 comments

Comments

@PiotrSikora
Copy link
Contributor

This is proposal to add Proxy Internal Response type that could be used to indicate that the response was generated by the intermediary (since we don't have any type that could be used in such case).

  • Name: proxy_internal_response
  • Description: The intermediary generated the response locally, without attempting to connect to the next hop (e.g. in response to a request to a debug endpoint terminated at the intermediary).
  • Extra Parameters: None.
  • Recommended HTTP status code:

PR: #806

cc @mnot

@PiotrSikora PiotrSikora changed the title proxy-status: add Proxy Internal Response. Proxy-Status: add Proxy Internal Response. May 3, 2019
@mnot
Copy link
Member

mnot commented Jul 1, 2019

We already have proxy_internal_error; maybe adjust that one to suit?

@PiotrSikora
Copy link
Contributor Author

Erm, those 2 have quite different purpose:

proxy_internal_error is Proxy-Status equivalent of 500 Internal Server Error, i.e. something is terribly broken and proxy couldn't handle the received request.

proxy_internal_response is supposed to indicate successful response generated by the proxy itself (e.g. in response to a request to a special debug URL like https://www.cloudflare.com/cdn-cgi/trace).

cc @alyssawilk

@mnot
Copy link
Member

mnot commented Jul 3, 2019

Got it. Merging, but we might want to look at the entire set and make sure we have enough context / prose around all of them (including this one) to make sure people understand the appropriate uses of them.

@mnot mnot closed this as completed Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants