Error levels seem too high

[BrianHicks]

I'm getting a lot of error messages in my logs for normal operations while using this library. For example, these three show up a lot:

erlzk/src/erlzk_conn.erl

Lines 273 to 287 in e6495a1

	terminate(normal, #state{socket=Socket}) ->
	gen_tcp:send(Socket, <<1:32, -11:32>>),
	gen_tcp:close(Socket),
	error_logger:warning_msg("Server is closed~n"),
	ok;
	terminate(shutdown, #state{socket=Socket}) ->
	gen_tcp:send(Socket, <<1:32, -11:32>>),
	gen_tcp:close(Socket),
	error_logger:warning_msg("Server is shutdown~n"),
	ok;
	terminate(Reason, #state{socket=Socket}) ->
	gen_tcp:send(Socket, <<1:32, -11:32>>),
	gen_tcp:close(Socket),
	error_logger:error_msg("Server is terminated: ~p~n", [Reason]),
	ok.

It would be my understanding that those would not need to be logged at all, and if they did they would be merely informative since they're normal shutdown conditions.

There are other conditions that are logged as warnings as well, such as

erlzk/src/erlzk_conn.erl

Line 362 in e6495a1

error_logger:warning_msg("Create a new connection to ~p:~p successful~n", [Host, Port]),

- a successful connection! Why should that trigger a warning?

Would you welcome a PR to tone these down a little?

[megayu]

I don't think that's a problem, just logging about connection status.

If you see a lot of these logging, the connection to ZooKeeper maybe unstable or the erlzk_conn process was be shut down a lot, none of these situations are normal, that's why i use warning.

[BrianHicks]

I get ‘em in my tests as well, which is where I’m seeing them a lot. Can you help me understand why a successful connection would merit a warning?

[megayu]

That's a successful reconnection after the link was broken, logging level of normal connection is info.

[BrianHicks]

Ahh, I see! Thanks for clarifying!

[megayu]

Looks like we are good here.