Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments are still integrated to the request #28

Closed
StephD opened this issue Aug 8, 2016 · 3 comments
Closed

Comments are still integrated to the request #28

StephD opened this issue Aug 8, 2016 · 3 comments
Labels

Comments

@StephD
Copy link

StephD commented Aug 8, 2016

  • VSCode Version: 1.4
  • OS Version: Win 7
  • REST Client Version: 0.7

Comments are integrated in the request.

  • Because you need a blank line between Content-type and Body (in POST request), if I put a comment instead of this blank line, the request will be not send.
  • If I put comment into the JSON body, my server will get that comment as a JSON form and a malformed JSON occur.

2016-08-08 17_18_18-mingw64__c_var_www__files_front_trace
Right side is my server log.

Proposition : Replace the comment with a blank line. BUT in a JSON form, blank line will generate a malformed JSON.

@Huachao
Copy link
Owner

Huachao commented Aug 8, 2016

@StephD I'd like to just ignore comment lines and won't treat them as blank lines. And the #test is sent to server is due to my bug.

@Huachao Huachao added the bug label Aug 8, 2016
@Huachao Huachao closed this as completed in 3c1690e Aug 8, 2016
@Huachao
Copy link
Owner

Huachao commented Aug 9, 2016

@StephD you can verify this in latest version 0.7.1. Thanks

@StephD
Copy link
Author

StephD commented Aug 9, 2016

Works well for the example I gave you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants