Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does it support client certificate authentication? #35

Closed
zephrxx opened this issue Sep 16, 2016 · 9 comments
Closed

Does it support client certificate authentication? #35

zephrxx opened this issue Sep 16, 2016 · 9 comments

Comments

@zephrxx
Copy link

zephrxx commented Sep 16, 2016

Some rest api requires client cert authentication.

@Huachao
Copy link
Owner

Huachao commented Sep 18, 2016

@zephrxx it's not supported now, thanks for your suggestion and I will put it in my backlog

@Huachao Huachao added this to the backlog milestone Sep 18, 2016
@Huachao Huachao removed this from the backlog milestone Dec 31, 2016
@ondrej-li
Copy link

This one should be fairly easy to implement. I can imagine 3 more items in the request:

  • client certificate
  • private key
  • private key password (optional)

All three can be in the plain text form, eligible for env. params substitution (environment aware).

https://www.npmjs.com/package/request#tlsssl-protocol for more.

@Huachao
Copy link
Owner

Huachao commented Jan 26, 2017

@defectus you are right, I am considering that how to let user to specify these items in request, the more direct way seems to put in request(that seems needs to create a new syntax to set these value), others ways are putting in setting files, or even add some dialogs to let user to CRUD these friendly

@ondrej-li
Copy link

Just keep in mind that for many people (at least for me :-)) client certificates differ between environments. We use different client certificates in production, staging and integration.

Whatever way you plan to implement this feature please allow us to easily configure certificates based on the selected environment.

@danielwagn3r
Copy link

An idea good be to use the underlaying OS certificate store which should work fine for Windows and MacOS. Referencing the Certificate could be done be specifing the store and fingerprint.

@Huachao
Copy link
Owner

Huachao commented Mar 22, 2017

@zephrxx @defectus @kwaxi @VitorLuizC @mFingers @ytimenkov I have implemented the client certificate feature, and will publish it in next version

@Huachao
Copy link
Owner

Huachao commented Apr 3, 2017

@zephrxx @defectus @kwaxi @VitorLuizC @mFingers @ytimenkov You can use the latest version 0.14.0, you can also follow the README for how to use it.

@ondrej-li
Copy link

Just tested it, works nicely! Good job, many thanks!

@MichaelHumplEnBW
Copy link

MichaelHumplEnBW commented Oct 11, 2023

There are two different interpretations of "client certificate authentication":

Is there a way to generate the client_assertion which is needed for the cert. based OAuth-Login to a Azure AD?
Thank you for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants